HHH-12556 Share data structures between similar LoadPlan based EntityLoaders #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, I'd like to merge it. |
|
@Sanne btw, I'm wondering if we should consider backporting it to 5.2. |
|
re: backporting. As you prefer. It makes sense to push some safe improvements to 5.2 so to have a larger pool of testers quickly, yet I also believe we should give motivation to ecnourage more aggressive updates. |
sebersole
approved these changes
May 9, 2018
|
@Sanne @sebersole merged and currently backporting to 5.2. @gbadner once this one gets a bit of field testing, it might be a good idea to backport it to 5.1. |
|
awesome! thanks @gsmet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of patch to improve our memory consumption when dealing with legacy batch fetch style.
With the Openbravo test case contributed by the OP, this change alone brings the memory used from 1002 MB to 461 MB.
I think this change is pretty safe API wise, that's why I isolated it.