-
Notifications
You must be signed in to change notification settings - Fork 3.6k
HHH-13228 - The modification of a @OneToOne with @MapsId property is silently ignored during a merge operation #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1848,4 +1848,8 @@ void attemptToAssociateProxyWithTwoOpenSessions( | |||
@LogMessage(level = WARN) | |||
@Message(value = "Using @AttributeOverride or @AttributeOverrides in conjunction with entity inheritance is not supported: %s. The overriding definitions are ignored.", id = 499) | |||
void unsupportedAttributeOverrideWithEntityInheritance(String entityName); | |||
|
|||
@LogMessage(level = WARN) | |||
@Message(value = "The [%s] property of the [%s] entity was modified, but it won't be updated because the property is immutable!", id = 500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a proper review but I think we should remove the exclamation point. It does not seem very professional to me.
Another thing is that we should check the full output of the Hibernate tests to check that this error message is not logged when it should not be.
514aecb
to
2233587
Compare
@gsmet I removed the exclamation mark. Related to logging this in other tests, this is the list of tests emitting this warning:
I need to go through them and see if the warning is justified. |
f7ac6b1
to
b04ccf7
Compare
After revising the check condition and fixing the
All tests show that, indeed, we try to update an immutable property and the message is justified. In fact, it's great that now we notify the user about this situation. |
This issues should me merge after this Pull Request. |
fb1bfd6
to
01e6fed
Compare
…silently ignored during a merge operation
01e6fed
to
072d8ca
Compare
@vladmihalcea Is there any plan to merge into 5.2.x and 5.3.x? Every project will not be using 5.4.x so I think this should be backported to previous versions. |
https://hibernate.atlassian.net/browse/HHH-13228