Skip to content

HHH-13269 - Embeddable collection regression due to HHH-11544 #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2019
Merged

HHH-13269 - Embeddable collection regression due to HHH-11544 #2782

merged 1 commit into from
Feb 22, 2019

Conversation

vladmihalcea
Copy link
Contributor

@vladmihalcea vladmihalcea requested a review from beikov February 15, 2019 08:33
@vladmihalcea
Copy link
Contributor Author

@beikov I created this fix for the HHH-13269 issue which adds a check for the EntityQuerySpace when creating the Join in the LoadQueryJoinAndFetchProcessor.

Let me know what you think.

@gsmet
Copy link
Member

gsmet commented Feb 21, 2019

@vladmihalcea I think we have the exact same problem here in the original PR: https://github.com/hibernate/hibernate-orm/pull/1844/files#diff-09dac74f012e7d7ef06e77ab10a33451R509

@gsmet gsmet added the 5.4 label Feb 21, 2019
@vladmihalcea
Copy link
Contributor Author

@gsmet @beikov Good catch. I updated the PR to include a check in DotNode as well. All tests pass successfully.

beikov
beikov approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vladmihalcea vladmihalcea merged commit 819f92c into hibernate:master Feb 22, 2019
@vladmihalcea vladmihalcea deleted the HHH-13269 branch February 22, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beikov beikov beikov approved these changes

Assignees
No one assigned
Labels
5.4 Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladmihalcea @gsmet @beikov