HHH-15086 Introduce configurable query cache layout #7543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
0cf03da to
0a63c1e
Compare
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java
Fixed
Show fixed
Hide fixed
...e-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowMultiselectTest.java
Fixed
Show fixed
Hide fixed
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java
Fixed
Show fixed
Hide fixed
...e-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowMultiselectTest.java
Fixed
Show fixed
Hide fixed
...te-core/src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionTest.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithDiscriminatorPolymorphicTest.java
Fixed
Show fixed
Hide fixed
.../src/main/java/org/hibernate/metamodel/mapping/internal/DiscriminatedAssociationMapping.java
Fixed
Show fixed
Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java
Fixed
Show fixed
Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java
Fixed
Show fixed
Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java
Fixed
Show fixed
Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java
Fixed
Show fixed
Hide fixed
...t/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowCollectionNestedJoinFetchTest.java
Fixed
Show fixed
Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java
Fixed
Show fixed
Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java
Fixed
Show fixed
Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java
Fixed
Show fixed
Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java
Fixed
Show fixed
Hide fixed
.../src/test/java/org/hibernate/orm/test/jpa/query/CachedQueryShallowWithJoinFetchLazyTest.java
Fixed
Show fixed
Hide fixed
8534062 to
46001c2
Compare
| ); | ||
| final CollectionPersister persister = collectionAttributeMapping.getCollectionDescriptor(); | ||
| // Try to reuse the previous collection key and collection if possible | ||
| if ( oldKey != null && persister.getKeyType().isEqual( oldKey.getKey(), collectionKeyValue ) ) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+90
to
+98
| return produceInitializer( | ||
| navigablePath, | ||
| attribute, | ||
| parentAccess, | ||
| lockMode, | ||
| collectionKeyAssembler, | ||
| collectionValueKeyAssembler, | ||
| creationState | ||
| ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| this.fetches = creationState.visitFetches( this ); | ||
| assert fetches.size() == 2; | ||
|
|
||
| discriminatorValueFetch = fetches.get( graphedPart.getDiscriminatorPart() ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
|
|
||
| @Override | ||
| public Fetch findFetch(Fetchable fetchable) { | ||
| if ( graphedPart.getDiscriminatorPart() == fetchable ) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| getConcreteDescriptor().getEntityName(), | ||
| uniqueKeyAttributePath, | ||
| rowProcessingState.getEntityUniqueKey(), | ||
| getConcreteDescriptor().getPropertyType( uniqueKeyAttributePath ), |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| void finishRowProcessing(RowProcessingState rowProcessingState); | ||
|
|
||
| default void finishRowProcessing(RowProcessingState rowProcessingState, boolean wasAdded) { | ||
| finishRowProcessing( rowProcessingState ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| * Callback at the end of processing the current "row" | ||
| */ | ||
| default void finishRowProcessing(boolean wasAdded) { | ||
| finishRowProcessing(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-15086