Skip to content

HHH-18262 - Composite Key Join HQL #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HHH-18262 - Composite Key Join HQL #8539

wants to merge 3 commits into from

Conversation

Akshit97
Copy link
Contributor

@Akshit97 Akshit97 commented Jun 8, 2024 •
edited by hibernate-github-bot bot
Loading

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 8, 2024
View reviewed changes
hibernate-core/src/test/java/org/hibernate/test/annotations/formula/CompositeKeyJoinTest.java
@Access(AccessType.PROPERTY)
public static class Event implements Serializable {

private Long id = new Random().nextLong();

Check warning

Code scanning / CodeQL

Random used only once Warning test

Random object created and used only once.
hibernate-core/src/main/java/org/hibernate/mapping/ManyToOne.java
@@ -38,7 +49,7 @@
}

public Type getType() throws MappingException {
return getMetadata().getTypeResolver().getTypeFactory().manyToOne(
Type type = getMetadata().getTypeResolver().getTypeFactory().manyToOne(

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MetadataImplementor.getTypeResolver
Loading
should be avoided because it has been deprecated.
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jun 9, 2024 •
edited
Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@Akshit97 Akshit97 force-pushed the feature-composite-join-5.6 branch from 5d44afe to e16251a Compare June 9, 2024 04:10
@gavinking gavinking mentioned this pull request Aug 28, 2024
Closed
gavinking
gavinking requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is targeting H5.6 when it should be targeting main.

Also, I would prefer to see it rolled into #8087.

Finally, I'm having trouble understanding the test and what it's even asserting. Would you please try to simplify it and make it a bit more understandable?

Thanks.

@Akshit97 Akshit97 changed the title HHH-17915 - Composite Key Join HQL HHH-18262 - Composite Key Join HQL Aug 29, 2024
@beikov
Copy link
Member

beikov commented Oct 4, 2024

Closing, since the Jira issue was already rejected.

@beikov beikov closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinking gavinking gavinking requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akshit97 @beikov @gavinking