Skip to content

Interaction: alert, prompt, confirm #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andreimuntean1
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bogdanbacosca bogdanbacosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te rog să dai revert la 13-while-for, cum ai făcut la celălalt PR.
Trebuie să avem doar 1 PR pentru fiecare articol.
Am lăsat 2 comentarii în cod.
Pe scurt: trebuie ca formatul markdown să fie identic cu cel original, iar numele variabilelor să rămână netraduse.
Te rog să faci schimbările astea mai intâi prin tot codul.
Dacă ai mai multe nelămuriri, citește fișierul README.md din repo sau trimite-mi un mail.

let name = prompt("What is your name?", "");
alert(name);
```js
let nume = prompt("Cum te numești?", "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let nume = prompt("Cum te numești?", "");
let name = prompt("Cum te numești?", "");

numele variabilelor nu se traduc.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants