Skip to content

Add Silent and implement setting optimizer attributes in caching and mock optimizers #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 13, 2019
Merged

Add Silent and implement setting optimizer attributes in caching and mock optimizers #695

merged 10 commits into from
Mar 13, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Mar 11, 2019 •
edited
Loading

  • Needs tests

Closes #663

@blegat blegat added this to the v0.8.4 milestone Mar 11, 2019
@codecov-io
Copy link

codecov-io commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #695 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   95.23%   95.24%   +<.01%     
==========================================
  Files          53       53              
  Lines        5546     5555       +9     
==========================================
+ Hits         5282     5291       +9     
  Misses        264      264
Impacted Files Coverage Δ
src/Utilities/cachingoptimizer.jl 93.95% <100%> (+0.23%) ⬆️
src/attributes.jl 97.29% <100%> (+0.03%) ⬆️
src/Utilities/mockoptimizer.jl 94.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eff7b4...0ec161b. Read the comment docs.

mlubin
mlubin reviewed Mar 12, 2019
View reviewed changes
mlubin
mlubin reviewed Mar 12, 2019
View reviewed changes
odow
odow reviewed Mar 12, 2019
View reviewed changes
@blegat blegat changed the title Add VerboseLevel and implement setting optimizer attributes in caching optimizer Add Silent and implement setting optimizer attributes in caching and mock optimizers Mar 13, 2019
@codecov-io
Copy link

codecov-io commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #695 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   95.23%   95.24%   +<.01%     
==========================================
  Files          53       53              
  Lines        5546     5555       +9     
==========================================
+ Hits         5282     5291       +9     
  Misses        264      264
Impacted Files Coverage Δ
src/Utilities/cachingoptimizer.jl 93.95% <100%> (+0.23%) ⬆️
src/attributes.jl 97.29% <100%> (+0.03%) ⬆️
src/Utilities/mockoptimizer.jl 94.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eff7b4...78ed02b. Read the comment docs.

mlubin
mlubin reviewed Mar 13, 2019
View reviewed changes
@blegat blegat merged commit 154e90f into master Mar 13, 2019
@odow odow deleted the bl/cachingoptattr branch April 28, 2019 21:26
@remi-garcia remi-garcia mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow left review comments

@mlubin mlubin mlubin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.8.4
Development

Successfully merging this pull request may close these issues.
4 participants
@blegat @codecov-io @mlubin @odow