Skip to content

Commit a6f3b62

Browse files
mikijoySaeed Mahameed
authored andcommitted
net/mlx5: Move devlink registration before interfaces load
Register devlink before interfaces are added. This will allow interfaces to use devlink while initalizing. For example, call mlx5_is_roce_enabled. Fixes: aba2527 ("net/mlx5e: Add TX reporter support") Signed-off-by: Michael Guralnik <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 99cda45 commit a6f3b62

File tree

1 file changed

+9
-7
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+9
-7
lines changed

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,6 +1193,12 @@ int mlx5_load_one(struct mlx5_core_dev *dev, bool boot)
11931193
if (err)
11941194
goto err_load;
11951195

1196+
if (boot) {
1197+
err = mlx5_devlink_register(priv_to_devlink(dev), dev->device);
1198+
if (err)
1199+
goto err_devlink_reg;
1200+
}
1201+
11961202
if (mlx5_device_registered(dev)) {
11971203
mlx5_attach_device(dev);
11981204
} else {
@@ -1210,6 +1216,9 @@ int mlx5_load_one(struct mlx5_core_dev *dev, bool boot)
12101216
return err;
12111217

12121218
err_reg_dev:
1219+
if (boot)
1220+
mlx5_devlink_unregister(priv_to_devlink(dev));
1221+
err_devlink_reg:
12131222
mlx5_unload(dev);
12141223
err_load:
12151224
if (boot)
@@ -1347,20 +1356,13 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *id)
13471356

13481357
request_module_nowait(MLX5_IB_MOD);
13491358

1350-
err = mlx5_devlink_register(devlink, &pdev->dev);
1351-
if (err)
1352-
goto clean_load;
1353-
13541359
err = mlx5_crdump_enable(dev);
13551360
if (err)
13561361
dev_err(&pdev->dev, "mlx5_crdump_enable failed with error code %d\n", err);
13571362

13581363
pci_save_state(pdev);
13591364
return 0;
13601365

1361-
clean_load:
1362-
mlx5_unload_one(dev, true);
1363-
13641366
err_load_one:
13651367
mlx5_pci_close(dev);
13661368
pci_init_err:

0 commit comments

Comments
 (0)