Skip to content

Add helper for mods #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Add helper for mods #95

merged 1 commit into from
Dec 29, 2021

Conversation

Roxedus
Copy link
Member

@Roxedus Roxedus commented Dec 29, 2021

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds a helper-function in $PATH for extension installation

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@Roxedus Roxedus requested a review from a team December 29, 2021 20:03
@thespad
Copy link
Member

thespad commented Dec 29, 2021

Should we document this in the app setup as well as the changelog note?

@Roxedus
Copy link
Member Author

Roxedus commented Dec 29, 2021

Im on the fence for documenting a function not intended for that type of use(even though I made sure it worked)

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aptalca aptalca merged commit 0a12acb into master Dec 29, 2021
@aptalca aptalca deleted the mod-helper branch December 29, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants