[ORC][Runtime] Enhancing ELF Platform with Push-Request Model for Initializers #102846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
1008b25 to
eec9d1c
Compare
|
This needs to be updated to resolve merge conflicts (you can just remove the method that I changed, and you'll need to wrap your function tag with |
c96559c to
2e946ab
Compare
6b5f004 to
8686784
Compare
lhames
approved these changes
Sep 25, 2024
|
Side note: |
|
@lhames I will create a new header for this. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/3788 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/2143 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/3440 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/2746 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/4297 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/4454 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of @lhames, this PR introduces a push-request model to manage list initializers in the runtime state for each
JITDylib, similar to howMachOandCOFFhandle it. Previously, the ELF runtime lacked the ability to register, deregister, or retain initializers, causing issues when re-runningdlopen. Initializers were erased afterrt_getInitializerswas used.To address this, we introduce
__orc_rt_elfnix_register_init_sectionsand__orc_rt_elfnix_register_jitdylib(and corresponding deregister functions). This model allows the runtime to request the push of initializers for theJITDylib, with the platform handling this via a record method. Additionally, we leverageMachO'sRecordSectionsTrackerto store initializers, ensuring only newly updated initializers are executed usingprocessNewSections, improving the runtime's efficiency and reliability.