Skip to content

[libc][math] Disable acoshf16 Test on AArch64 to resolve test failures. #132580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

harrisonGPU
Copy link
Contributor

No description provided.

@harrisonGPU harrisonGPU requested a review from lntue March 23, 2025 03:04
@llvmbot llvmbot added the libc label Mar 23, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 23, 2025

@llvm/pr-subscribers-libc

Author: Harrison Hao (harrisonGPU)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/132580.diff

1 Files Affected:

  • (modified) libc/config/linux/aarch64/entrypoints.txt (+1-1)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 75acb989971ad..bca0b13feb1a0 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -645,7 +645,7 @@ endif()
 if(LIBC_TYPES_HAS_FLOAT16)
   list(APPEND TARGET_LIBM_ENTRYPOINTS
     # math.h C23 _Float16 entrypoints
-    libc.src.math.acoshf16
+    # libc.src.math.acoshf16
     libc.src.math.canonicalizef16
     libc.src.math.ceilf16
     libc.src.math.copysignf16

@harrisonGPU
Copy link
Contributor Author

@lntue I will try to investigate this failing test, and for now, I have temporarily disabled it.

@harrisonGPU harrisonGPU changed the title [libc][math] Fix acoshf16 test issue on aarch64. [libc][math] Disable acoshf16 Test on AArch64 to resolve test failures. Mar 23, 2025
@harrisonGPU harrisonGPU merged commit ebcf1de into llvm:main Mar 23, 2025
18 checks passed
@harrisonGPU harrisonGPU deleted the fixLibc branch March 23, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants