Skip to content

[flang][test] fix sporadically failing test #134608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

tblah
Copy link
Contributor

@tblah tblah commented Apr 7, 2025

The test is checking output from MLIR debug prints. MLIR passes can be executed in parallel, for example a pass on func.func might schedule different func.func operations in different threads. This led to intermittent test failures where debug output from different threads became mixed up.

Fix by disabling mlir multithreading for this test.

The test is checking output from MLIR debug prints. MLIR passes can be
executed in parallel, for example a pass on func.func might schedule
different func.func operations in different threads. This led to
intermittent test failures where debug output from different threads
became mixed up.

Fix by disabling mlir multithreading for this test.
@tblah tblah requested review from DavidSpickett and ergawy April 7, 2025 11:01
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Apr 7, 2025
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tblah tblah merged commit b9c876d into llvm:main Apr 7, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants