[lldb-dap] Fix win32 build.

[ashgti]

This enum was not fully specified.

[ashgti]

This should fix https://lab.llvm.org/buildbot/#/builders/197/builds/3983

[llvmbot]

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

This enum was not fully specified.

---

Full diff: https://github.com/llvm/llvm-project/pull/135638.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/Transport.cpp (+1-1)

diff --git a/lldb/tools/lldb-dap/Transport.cpp b/lldb/tools/lldb-dap/Transport.cpp
index 96b8a48fdf61e..ffd0c49f1770b 100644
--- a/lldb/tools/lldb-dap/Transport.cpp
+++ b/lldb/tools/lldb-dap/Transport.cpp
@@ -38,7 +38,7 @@ ReadFull(IOObject &descriptor, size_t length,
   bool timeout_supported = true;
   // FIXME: SelectHelper does not work with NativeFile on Win32.
 #if _WIN32
-  timeout_supported = descriptor.GetFdType() == eFDTypeSocket;
+  timeout_supported = descriptor.GetFdType() == IOObject::eFDTypeSocket;
 #endif
 
   if (timeout && timeout_supported) {

[slydiman]

@ashgti Did you test #130169 on Windows?
This patch will fix the building, but I'm not sure that it will work on Windows considering this:

// TODO: On Windows this should be a HANDLE, and wait should use
// WaitForMultipleObjects
typedef int WaitableHandle;

IOObject::WaitableHandle Socket::GetWaitableHandle() {
  // TODO: On Windows, use WSAEventSelect
  return m_socket;
}

It seems you need a Windows specific implementation.

[ashgti]

@ashgti Did you test #130169 on Windows? This patch will fix the building, but I'm not sure that it will work on Windows considering this:

SelectHelper has a Windows implementation:

llvm-project/lldb/source/Utility/SelectHelper.cpp

Line 93 in a43ff0e

lldb_private::Status SelectHelper::Select() {

it only works with Socket types on Windows.