[Tablegen] Add keyword `dump`. #68793

fpetrogalli · 2023-10-11T11:20:00Z

The keyword is intended for debugging purpose. It prints a message to stderr.

This patch is based on code originally written by Adam Nemet, and on the feedback received by the reviewers in
https://reviews.llvm.org/D157492.

The keyword is intended for debugging purpose. It prints a message to stderr. This patch is based on code originally written by Adam Nemet, and on the feedback received by the reviewers in https://reviews.llvm.org/D157492.

llvm/lib/TableGen/TGParser.cpp

nhaehnle

Acked, modulo some minor nits and a suggestion.

Typo in the title: "keywork"

llvm/docs/TableGen/ProgRef.rst

llvm/lib/TableGen/Error.cpp

llvm/test/TableGen/dump.td

llvm/lib/TableGen/TGParser.cpp

Added a comment to the place were we could make repr look recursively into a list.

wangpc-pp

LGTM but please wait for others.

llvm/lib/TableGen/Record.cpp

wangpc-pp · 2023-10-12T12:05:55Z

Oh! Don't forget to add a ReleaseNote!

fpetrogalli · 2023-10-12T14:02:19Z

Oh! Don't forget to add a ReleaseNote!

I prepared a separate patch for both dump and !repr: #68893.

* `dump`, added in llvm#68793 * `!repr`, added in llvm#68716 The keyword `assert` was missing, so I have added that too.

Artem-B

LGTM, with a few nits/suggestions.

llvm/docs/TableGen/ProgRef.rst

llvm/lib/TableGen/Error.cpp

llvm/lib/TableGen/Record.cpp

llvm/test/TableGen/dump.td

github-actions · 2023-10-13T09:23:27Z

✅ With the latest revision this PR passed the C/C++ code formatter.

The text is inspired by the similar items in of `assert` keyword.

fpetrogalli · 2023-10-13T11:44:34Z

@Artem-B

I wonder what the dump from multiple instances of in-multiclass dump would look like. Can we tell them apart somehow? I think they all will be attributed to the source location of the dump itself. I think we'll need some sort of reference to the instantiation point, too.

I like this a lot - it can get nasty if someone start using dump statements across layers of class/multiclass indirection.
I actually had the same issue with assert, which does not come as surprise given the similarities with dump.

Not sure if it's worth it, but I think it would be useful. We can consider it as a follow-up change.

If this is OK with you, I will create an issue and link it to this PR.

fpetrogalli · 2023-10-18T16:53:23Z

@Artem-B - gentle ping, I'd like to get a final blessing from you.

Francesco

Artem-B

LGTM, with one suggestion for the docs.

llvm/docs/TableGen/ProgRef.rst

* `dump`, added in #68793 * `!repr`, added in #68716

…68897) * `dump`, added in #68793 * `!repr`, added in #68716 The keyword `assert` was missing, so I have added that too.

…ators. (#68897) * `dump`, added in llvm/llvm-project#68793 * `!repr`, added in llvm/llvm-project#68716 The keyword `assert` was missing, so I have added that too.

…#68897) * `dump`, added in llvm/llvm-project#68793 * `!repr`, added in llvm/llvm-project#68716 The keyword `assert` was missing, so I have added that too.

[Tablegen] Add keywork dump.

004967c

The keyword is intended for debugging purpose. It prints a message to stderr. This patch is based on code originally written by Adam Nemet, and on the feedback received by the reviewers in https://reviews.llvm.org/D157492.

fpetrogalli requested a review from Artem-B October 11, 2023 11:20

fpetrogalli commented Oct 11, 2023

View reviewed changes

llvm/lib/TableGen/TGParser.cpp Outdated Show resolved Hide resolved

Rename var. [NFC]

59813e6

fpetrogalli requested a review from nhaehnle October 11, 2023 11:22

wangpc-pp self-requested a review October 11, 2023 11:43

nhaehnle reviewed Oct 11, 2023

View reviewed changes

llvm/docs/TableGen/ProgRef.rst Outdated Show resolved Hide resolved

llvm/docs/TableGen/ProgRef.rst Outdated Show resolved Hide resolved

llvm/lib/TableGen/Error.cpp Outdated Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/Error.cpp Outdated Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/Error.cpp Outdated Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/Error.cpp Outdated Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/test/TableGen/dump.td Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/TGParser.cpp Outdated Show resolved Hide resolved

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/TGParser.cpp Show resolved Hide resolved

fpetrogalli added 10 commits October 12, 2023 09:54

Update llvm/docs/TableGen/ProgRef.rst

0fab2a6

Update llvm/docs/TableGen/ProgRef.rst

71e687d

Update llvm/lib/TableGen/Error.cpp

6cc1fa7

s/CheckDump/dumpMessage

3a1192b

Use the correct Loc.

d4223ea

test for warning on not using a string.

97187e7

Print a warning instead of a note if the dump operand is not a string.

9c923a5

Test if/foreach/defvar [NFCI].

346574f

Check the use of dump in class, even through inhertance.

4d77fc8

Test dump on defset.

cd815df

Added a comment to the place were we could make repr look recursively into a list.

fpetrogalli changed the title ~~[Tablegen] Add keywork dump.~~ [Tablegen] Add keyword dump. Oct 12, 2023

wangpc-pp reviewed Oct 12, 2023

View reviewed changes

llvm/lib/TableGen/Record.cpp Outdated Show resolved Hide resolved

s/checkRecordDumps/emitRecordDumps/ [NFC]

977666e

fpetrogalli mentioned this pull request Oct 12, 2023

[TableGen] Update editor modes for new keywords and bang operators. #68897

Merged

fpetrogalli added the tablegen label Oct 12, 2023

fpetrogalli mentioned this pull request Oct 12, 2023

[ReleaseNotes][TableGen] Add dump and !repr. #68893

Merged

Artem-B approved these changes Oct 12, 2023

View reviewed changes

llvm/docs/TableGen/ProgRef.rst Show resolved Hide resolved

llvm/lib/TableGen/Error.cpp Outdated Show resolved Hide resolved

llvm/lib/TableGen/Record.cpp Outdated Show resolved Hide resolved

llvm/test/TableGen/dump.td Show resolved Hide resolved

fpetrogalli added 2 commits October 13, 2023 11:10

Update coment in llvm/lib/TableGen/Record.cpp [NFC]

529758f

Apply clang-format to latest commit. [NFC]

3fd5df2

fpetrogalli added 5 commits October 13, 2023 12:23

Allow dumping of def and defvar directly.

7164ec4

Remove unused variable. [NFC]

45f067b

Enforce dumpMessage to require a StringInit to print.

2562922

[docs] Explain when the messages are instantiated. [NFC]

36a00b8

The text is inspired by the similar items in of `assert` keyword.

Add test case with multiple nested defm. [NFC]

5ffabf3

Fix code formmatting [NFC]

f270615

Artem-B approved these changes Oct 18, 2023

View reviewed changes

llvm/docs/TableGen/ProgRef.rst Outdated Show resolved Hide resolved

Update docs after review feedback in llvm#68793 (comment)

3c1f83d

fpetrogalli merged commit db9b6f4 into llvm:main Oct 19, 2023

fpetrogalli added a commit that referenced this pull request Oct 19, 2023

[ReleaseNotes][TableGen] Add dump and !repr. (#68893)

411c4ed

* `dump`, added in #68793 * `!repr`, added in #68716

fpetrogalli added a commit that referenced this pull request Oct 19, 2023

[TableGen] Update editor modes for new keywords and bang operators. (#…

4168845

…68897) * `dump`, added in #68793 * `!repr`, added in #68716 The keyword `assert` was missing, so I have added that too.

madhur13490 mentioned this pull request Oct 20, 2023

Revert commit ba8565fbcb975e2d067ce3ae5a7dbaae4953edd3 madhur13490/llvm-project#3

Closed

banach-space mentioned this pull request Oct 24, 2023

[mlir][vector] Add scalable vectors to tests for vector.contract #70039

Merged

[Tablegen] Add keyword dump. #68793

[Tablegen] Add keyword dump. #68793

Uh oh!

Conversation

fpetrogalli commented Oct 11, 2023

Uh oh!

Uh oh!

nhaehnle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangpc-pp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wangpc-pp commented Oct 12, 2023

Uh oh!

fpetrogalli commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Artem-B left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fpetrogalli commented Oct 13, 2023

Uh oh!

fpetrogalli commented Oct 18, 2023

Uh oh!

Artem-B left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[Tablegen] Add keyword `dump`. #68793

[Tablegen] Add keyword `dump`. #68793

fpetrogalli commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023 •

edited

Loading