Skip to content

[IR] Fix typo in trunc nuw semantics; NFC #87285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

programmerjake
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 1, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the llvm:ir label Apr 1, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 1, 2024

@llvm/pr-subscribers-llvm-ir

Author: Jacob Lifshay (programmerjake)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/87285.diff

1 Files Affected:

  • (modified) llvm/docs/LangRef.rst (+1-1)
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 1d4ff5238226c2..fbdd4c641fc94a 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -11445,7 +11445,7 @@ and converts the remaining bits to ``ty2``. Since the source size must
 be larger than the destination size, ``trunc`` cannot be a *no-op cast*.
 It will always truncate bits.
 
-If the ``nuw`` keyword is present, and any of the truncated bits are zero,
+If the ``nuw`` keyword is present, and any of the truncated bits are non-zero,
 the result is a :ref:`poison value <poisonvalues>`. If the ``nsw`` keyword
 is present, and any of the truncated bits are not the same as the top bit
 of the truncation result, the result is a :ref:`poison value <poisonvalues>`.

@goldsteinn goldsteinn changed the title Fix typo in trunc nuw semantics [IR] Fix typo in trunc nuw semantics; NFC Apr 1, 2024
@programmerjake
Copy link
Contributor Author

@goldsteinn should I amend the commit title to include [IR]?

@goldsteinn
Copy link
Contributor

@goldsteinn should I amend the commit title to include [IR]?

No need (didn't see it was already merged)

@programmerjake
Copy link
Contributor Author

@goldsteinn should I amend the commit title to include [IR]?

No need (didn't see it was already merged)

afaict this hasn't been merged yet, not sure what you mean by that...

@goldsteinn
Copy link
Contributor

@goldsteinn should I amend the commit title to include [IR]?

No need (didn't see it was already merged)

afaict this hasn't been merged yet, not sure what you mean by that...

hehe, yeah saw the merged tag on the PR you linked.

Yeah change the commit message.

Copy link
Member

@elhewaty elhewaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@dtcxzyw dtcxzyw merged commit da5a86b into llvm:main Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

@programmerjake Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants