Add additional case-insensitive text support #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGabriel
commented
Nov 23, 2017
tools/GenTypeInfo.hs
Outdated
| |] | ||
| citext | ||
| _citext array_citext | ||
| |] -- Note: You must enable the citext extension (CREATE EXTENSION IF NOT EXISTS citext) to generate the citext values |
There was a problem hiding this comment.
I could make the script do this automatically as well
There was a problem hiding this comment.
You can't do this, because the type oid of citext is not stable from database to database. You need to remove this from the static typeinfo, and should be using the textual name for type checking instead. See the documentation in the FromField module, and the hstore instances for an example.
There was a problem hiding this comment.
Ok, I’ll remove this
MaxGabriel
commented
Nov 23, 2017
CHANGES.md
Outdated
| * Added `ToField` instances for case-insensitive strict and lazy text. | ||
| Added `citext` and `_citext` to `Database.PostgreSQL.Simple.TypeInfo.Static`. | ||
| Thanks to Max Tagher for the implementation. | ||
|
|
There was a problem hiding this comment.
Wasn't sure if you wanted contributors to make their own changes to the changelog
There was a problem hiding this comment.
Doesn't matter much to me one way or the other. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
I'm not positive I understand the conclusion from this comment thread: bcbacfe
I don't think that supporting case insensitive Strings or ByteStrings is a goal of postgresql-simple, though, just based on my impression of the library (and like you said, it would be preferable to use bytea for ByteString).
@bergmark mentioned having newtypes around text, and it would be nice to support those. I suspect you'd more often be making newtypes around
CI Textthough (newtype Foo = Foo (CI Text) deriving (Show, Eq, ToField, FromField)), in which case you could useGeneralizedNewtypeDerivingto get theFromField/ToFieldinstances.