This repository was archived by the owner on Nov 19, 2024. It is now read-only.
add documentation for assignCustomerToGuestCart mutation #9252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbess
approved these changes
Nov 17, 2021
keharper
reviewed
Nov 19, 2021
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
keharper
suggested changes
Dec 2, 2021
|
|
||
| The `assignCustomerToGuestCart` mutation assigns a logged in customer and merge customer's shopping cart items to the specified guest shopping cart. | ||
|
|
||
| The customer must be logged in (You must specify the customer’s authorization token in the headers). |
There was a problem hiding this comment.
Replace this line with the standard "This mutation requires a valid customer authentication token." and move it to the bottom of this section.
| Customer now is assigned to that active cart. | ||
|
|
||
| *Note:* | ||
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. |
There was a problem hiding this comment.
Why are masked_id and quote_id mentioned here, when neither are part of the request or response?
There was a problem hiding this comment.
Hi @keharper , I mentioned them because I think it's a useful information for the developers, who can be confused why there is no old masked_id in the database, but a new one appeared instead.
I can remove this note if you think that it's unnecessary information.
There was a problem hiding this comment.
Suggested change
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. | |
| The `masked_id` of the guest cart contains a new value. The `quote_id` remains the same. |
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
|
@karyna-tsymbal-atwix |
3e09345 to
2db4e9d
Compare
2db4e9d to
d247290
Compare
keharper
suggested changes
Jan 4, 2022
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
| Customer now is assigned to that active cart. | ||
|
|
||
| *Note:* | ||
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. |
There was a problem hiding this comment.
Suggested change
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. | |
| The `masked_id` of the guest cart contains a new value. The `quote_id` remains the same. |
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
keharper
approved these changes
Jan 5, 2022
|
@magento import code to magento-devdocs/devdocs |
|
@keharper the branch with the code is successfully imported into the |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds a documentation page for the
assignCustomerToGuestCartmutation (GraphQL).Magento 2 GitHub Issue: magento/magento2#32615
Magento 2 GitHub PR: magento/magento2#33106
Fixes #9248
Affected DevDocs pages
Links to Magento source code
whatsnew
Added the
assignCustomerToGuestCartmutation.