Skip to content

[Story] 543: Content Product Attributes Default Sorting Order #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2020
Merged

[Story] 543: Content Product Attributes Default Sorting Order #585

merged 4 commits into from
Aug 6, 2020

Conversation

bluemwhitew
Copy link
Contributor

@bluemwhitew bluemwhitew commented Jul 24, 2020 •
edited by lbvaimo
Loading

Description (*)

Reordered the description and short_description product attributes to better accommodate planned Page Builder content staging changes.

Fixed Issues

  1. https://www.github.com/magento/magento2-page-builder/issues/543

Builds

N/A

Related Pull Requests

https://www.github.com/magento/magento2/pull/29238

Questions or Comments

N/A

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Test Plan

Manual Testing Scenarios

  • New Magento Installation
  1. Create a new Product (Catalog » Products » Add Product)
  2. Expand the Content accordion
  3. Verify that Short Description appears before Description
  • Existing Magento Installation:
  1. Create a new Product (Catalog » Products » Add Product)
  2. Expand the Content accordion
  3. Verify that Description appears before Short Description
  4. Update to include this changeset
  5. Run php bin/magento setup:upgrade
  6. Create a new Product (Catalog » Products » Add Product)
  7. Expand the Content accordion
  8. Verify that Short Description appears before Description
  • Attribute Sorting in Admin:
  1. Modify Attribute Sets (Stores » Attributes » Attribute Set)
  2. Click on the "Default" Attribute Set
  3. Switch the order of description and short_description respectively
  4. Click Save
  5. Create a new Product (Catalog » Products » Add Product)
  6. Expand the Content accordion
  7. Verify that Description appears before Short Description

Automated MFTF Tests

  • No new tests needed
    -- Scenarios are not high enough priority
  • Update existing tests to pass

Manual Hip Tests

  • No new tests needed. No updated tests needed
    -- Scenarios are not high enough priority

@bluemwhitew
Copy link
Contributor Author

@magento run all tests

@bluemwhitew bluemwhitew linked an issue Jul 24, 2020 that may be closed by this pull request
Content product attributes default sorting order #543
Closed
@bluemwhitew bluemwhitew added PAP Page Builder Partner: Vaimo https://www.vaimo.com Progress: review labels Jul 24, 2020
@ghost ghost added 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: and removed 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: labels Jul 27, 2020
@bluemwhitew
Copy link
Contributor Author

@magento run all tests

@bluemwhitew
Copy link
Contributor Author

@magento run Functional Tests B2B

@lbvaimo
Copy link

lbvaimo commented Jul 28, 2020 •
edited
Loading

Test for new Magento Installation result

  • Verify that Short Description appears before Description
    image
    Everything works as expected 🥇

Test for Existing Magento Installation:

  • Verify that Description appears before Short Description
    image
  • Verify that Short Description appears before Description
    image
    Everything works as expected 🥇

Test for Attribute Sorting in Admin:

  • Verify that Description appears before Short Description
    image
    Everything works as expected 🥇

@omiroshnichenko omiroshnichenko changed the title magento/magento2-page-builder#543: Content Product Attributes Default Sorting Order [Story] 543: Content Product Attributes Default Sorting Order Jul 31, 2020
@lbvaimo lbvaimo changed the base branch from develop to 1.5.0-release August 5, 2020 12:22
@bluemwhitew
Copy link
Contributor Author

@magento run all tests

@bluemwhitew bluemwhitew mentioned this pull request Aug 5, 2020
Merged
7 tasks
@omiroshnichenko omiroshnichenko changed the base branch from 1.5.0-release to develop August 6, 2020 13:59
@omiroshnichenko omiroshnichenko merged commit 5327b7e into develop Aug 6, 2020
@bluemwhitew bluemwhitew deleted the 543_product-attributes-default-sorting-order branch August 6, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

@dhaecker dhaecker dhaecker approved these changes

Assignees

@omiroshnichenko omiroshnichenko

@dhaecker dhaecker

Labels
2.4-develop: dep 2.4-develop: dep L3: Passed QA PAP Page Builder Partner: Vaimo https://www.vaimo.com Progress: done Test Plan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content product attributes default sorting order
4 participants
@bluemwhitew @lbvaimo @omiroshnichenko @dhaecker