Skip to content

Fixing strict sprintf Phrases in php8 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fixing strict sprintf Phrases in php8 #780

merged 1 commit into from
Sep 22, 2021

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR aims to fix rendering the Phrases in sprintf, which gets only string param.

Story

Bug

Task

Fixed Issues (if relevant)

  1. The problem with sprintf(Magento\Framwork\Phrase()) construction in PHP >= 8 magento2#34085

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@eduard13 eduard13 changed the title Fixing phrases Fixing strict sprintf Phrases Sep 17, 2021
@eduard13 eduard13 changed the title Fixing strict sprintf Phrases Fixing strict sprintf Phrases in php8 Sep 17, 2021
@eduard13 eduard13 mentioned this pull request Sep 17, 2021
Merged
5 tasks
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 force-pushed the php8-compatibility/fix-magento-phrases branch from ede93d9 to b81b1b7 Compare September 17, 2021 10:13
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 54c7a40 into magento:platform-health Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@andrewbess andrewbess

@sidolov sidolov

Labels
Partner: Atwix partners-contribution Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eduard13 @andrewbess @sidolov @magento-engcom-team @magento-devops-reposync-svc