Alt text for Images, Banners and Slides for better accessibility and SEO #787

manavluhar · 2021-10-11T11:55:11Z

Description (*)

SEO Fieldset in Page Builder Image / Banner / Slide
Banner SEO in frontend
Slider SEO in Frontend
Image is already having SEO functionality

Story

746 Alt text for Images

Fixed Issues (if relevant)

Alt text for Images #746: Alt text for Images

Manual testing scenarios (*)

By going inside Admin Panel -> CONTENT -> Pages -> Edit Home page open Content section and click on Edit with Page Builder button.
Add New Banner/Add New Slider -> Hover on the Banner Area / Edit Slide -> Click On ⚙️[Edit] Here admin can find Search Engin Optimization Fieldset.
Inside Search Engin Optimization Fieldset Alternative Text and Title Attribute fields will be there.
After filling required fields, One can check by going to the Storefront -> Home page and inspect Banner / Slide / Image and check that Alternative Text and Title Attribute will be there which makes PageBuilder content accessible and SEO optimized

Questions or comments

Checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

manavluhar · 2021-10-11T11:56:46Z

@magento run all tests

magento-automated-testing · 2021-10-11T11:56:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2021-10-11T14:49:03Z

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

magento-automated-testing · 2021-10-11T14:49:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2021-10-11T17:44:17Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-10-11T17:44:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2021-10-11T20:44:21Z

@magento run Unit Tests

magento-automated-testing · 2021-10-11T20:44:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-12T21:01:57Z

@magento run Unit Tests

magento-automated-testing · 2021-10-12T21:02:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov

@manavluhar changes look good to me. Could you please cover new functionality with MFTF test? (maybe a good idea to find already created tests and edit them to fill new fields and then check them on the storefront)

manavluhar · 2021-10-14T05:03:22Z

Sure @sidolov will do that! 🙌

manavluhar · 2021-10-17T19:49:50Z

@magento run all tests

magento-automated-testing · 2021-10-17T19:49:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

manavluhar · 2021-10-18T06:17:38Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

magento-automated-testing · 2021-10-18T06:17:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sdzhepa · 2021-10-20T18:47:06Z

UPDATE on 11 Nov 2021

This PR requires additional discussion with PO

images already have ALT attributes
adding ALT attribute allowed only to the <image> tag, but not for <div> https://www.w3schools.com/tags/att_alt.asp

Admin Side

New Section "Search Engine Optimization" was added to the Banner and Slider PageBuilder content types.
The section contains new fields/settings: "Alternative Text" and " Title Attribute"

Was tested that these options exist and Admin users can edit them.
Was tested these attributes are available(shown) on the Storefront

Banner

Slider(available per each slide)

Storefront Side

Banner

Slider(available per each slide)

sidolov · 2021-10-26T20:51:25Z

@magento run all tests

magento-automated-testing · 2021-10-26T20:51:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-11-12T17:39:06Z

@magento run all tests

sidolov · 2021-11-24T18:55:22Z

@magento run Functional Tests B2B,Unit Tests

magento-automated-testing · 2021-11-24T18:55:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sdzhepa · 2021-11-24T19:09:32Z

QA Passed after reworking of PR

Were tested next Page Builder entities: Banner, Image, Slider
Were tested when this entity inside Row and Tab "containers"

image tag has added alt attribute
for div was used aria-label instead.

Additional was performed testing using Screen Reader: All alternative text for all these entities can be read by screen reader

Note: Looks like implementation is done, only some failed functional tests. Fails look like related to the incorrect locators. So i assume no code changes just fix test. But in case if any code changes will be performed to change implementation/logic pls ping me for one more testing round

sidolov · 2021-11-29T20:19:39Z

@magento run all tests

magento-automated-testing · 2021-11-29T20:19:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-11-29T23:27:19Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE,WebAPI Tests

magento-automated-testing · 2021-11-29T23:27:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-11-30T15:16:02Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-automated-testing · 2021-11-30T15:16:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-11-30T17:53:27Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-automated-testing · 2021-11-30T17:53:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-11-30T21:57:52Z

@magento run all tests

magento-automated-testing · 2021-11-30T21:57:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-12-01T14:03:27Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-automated-testing · 2021-12-01T14:03:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-12-01T16:43:30Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

magento-automated-testing · 2021-12-01T16:43:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-12-01T19:13:34Z

@magento run Functional Tests B2B,Functional Tests CE

magento-automated-testing · 2021-12-01T19:13:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-12-01T21:52:40Z

@magento run Functional Tests B2B,Functional Tests CE

magento-automated-testing · 2021-12-01T21:52:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-02T14:58:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-02T17:35:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-12-02T18:47:00Z

@magento import pr to magento-commerce/magento2-page-builder

m2-github-services · 2021-12-02T18:48:00Z

@sidolov the Pull Request is successfully imported.

Alt text for Images, Banners and Slides for better accessibility and SEO

5b4410f

m2-community-project bot added the Progress: ready for review label Oct 11, 2021

sidolov requested changes Oct 13, 2021

View reviewed changes

m2-community-project bot assigned sidolov Oct 13, 2021

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels Oct 13, 2021

sidolov added the Priority: P1 Priority: P1 label Oct 15, 2021

Covering new functionality with MFTF test

fec2eca

sdzhepa linked an issue Oct 20, 2021 that may be closed by this pull request

Alt text for Images #746

Closed

magento#787: Tests stabilization

1755d80

magento#787: Tests stabilization

98b8d2f

magento#787: Fixed issue with attributes

6ea28dd

Merge remote-tracking branch 'origin/develop' into manavluhar/seo

7ad0204

magento-devops-reposync-svc merged commit cadd3d2 into magento:develop Dec 8, 2021

m2-community-project bot added Progress: done and removed Progress: approved labels Dec 8, 2021

Alt text for Images, Banners and Slides for better accessibility and SEO #787

Alt text for Images, Banners and Slides for better accessibility and SEO #787

Uh oh!

Conversation

manavluhar commented Oct 11, 2021 • edited by sdzhepa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Story

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Checklist

Uh oh!

manavluhar commented Oct 11, 2021

Uh oh!

magento-automated-testing bot commented Oct 11, 2021

Uh oh!

manavluhar commented Oct 11, 2021

Uh oh!

magento-automated-testing bot commented Oct 11, 2021

Uh oh!

manavluhar commented Oct 11, 2021

Uh oh!

magento-automated-testing bot commented Oct 11, 2021

Uh oh!

manavluhar commented Oct 11, 2021

Uh oh!

magento-automated-testing bot commented Oct 11, 2021

Uh oh!

sidolov commented Oct 12, 2021

Uh oh!

magento-automated-testing bot commented Oct 12, 2021

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

manavluhar commented Oct 14, 2021

Uh oh!

manavluhar commented Oct 17, 2021

Uh oh!

magento-automated-testing bot commented Oct 17, 2021

Uh oh!

manavluhar commented Oct 18, 2021

Uh oh!

magento-automated-testing bot commented Oct 18, 2021

Uh oh!

sdzhepa commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Admin Side

Banner

Slider(available per each slide)

Storefront Side

Banner

Slider(available per each slide)

Uh oh!

sidolov commented Oct 26, 2021

Uh oh!

magento-automated-testing bot commented Oct 26, 2021

Uh oh!

sidolov commented Nov 12, 2021

Uh oh!

sidolov commented Nov 24, 2021

Uh oh!

magento-automated-testing bot commented Nov 24, 2021

Uh oh!

sdzhepa commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidolov commented Nov 29, 2021

Uh oh!

magento-automated-testing bot commented Nov 29, 2021

Uh oh!

sidolov commented Nov 29, 2021

Uh oh!

magento-automated-testing bot commented Nov 29, 2021

Uh oh!

sidolov commented Nov 30, 2021

Uh oh!

magento-automated-testing bot commented Nov 30, 2021

Uh oh!

manavluhar commented Oct 11, 2021 •

edited by sdzhepa

Loading

sdzhepa commented Oct 20, 2021 •

edited

Loading

sdzhepa commented Nov 24, 2021 •

edited

Loading