Invoice order with only 1 configurable product is not treated as last invoice [CE 2.2.3]

[qlhu]

Preconditions (*)

1. Magento CE 2.2.3

Steps to reproduce (*)

1. Add a configurable product to cart
2. Complete the order with any payment method allowed to invoice
3. Invoice the order from Admin and debug this action

Expected result (*)

1. The invoice is treated as last invoice and Magento\Sales\Model\Order\Invoice\Total\Tax::collect() line 94 - 97 is executed.

Actual result (*)

1. The invoice is not treated as last invoice and Magento\Sales\Model\Order\Invoice\Total\Tax::collect() line 99 - 105 is executed.

The child item of configurable order item is treated as dummy but it's involved in the test if the item is to be invoiced completely. This issue

[m2-assistant]

Hi @qlhu. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@qlhu do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

hi @qlhu thank you for you report, this issue has already fixed in 2.3-develop branch, but i think this may be related to your custom modules.

[qlhu]

Hi @engcom-backlog-nazar,
Thanks for quick response. Could you confirm it executes line 102 - 105 of Magento\Sales\Model\Order\Invoice\Total\Tax::collect() instead the line 107 - 113 when you did debugging? By reviewing 2.3-develop branch, thought the line 107 - 113 would to be executed.
Please let me share what I figured out with Magento CE 2.2.3. The configurable child item is treated as dummy and the Magento\Sales\Model\Order\Item::getQtyToInvoice() returns 0. And the Magento\Sales\Model\Order\Invoice\Item::getQty() returns 1 or any digit > 0. That leads Magento\Sales\Model\Order\Invoice\Item::isLast() returns false and then the invoice is not treated as last invoice.

[mizzimizzi]

Hello!
I'm having the same problem, any suggestions on how to proceed?