Bundles and tier price give unexpected results

[kassner]

Preconditions

1. Magento Open Source 2.3.1;
2. Create a simple product with price $10.00 and tier price of $9.00 for 2 or more quantities;
3. Create a bundle product, with only one option, and add the simple product as the only selection, use Quantity = 2 and User defined = unchecked;

Steps to reproduce

1. Go to the bundle product page on the frontend;
2. Select qty = 1 and click add to cart. Minicart shows correct prices (unit $18, total $18);
3. Without leaving the page, select qty = 2 and click add to cart. Minicart shows wrong prices (unit $36, total $108, should be $18/$54);

4. Without leaving the page, select qty = 3 and click add to cart. Minicart shows wrong prices (unit $54, total $324, should be $18/$108);

5. Click Proceed to Checkout. Order summary has the wrong total:

6. Place the order;
7. Go to Admin > Sales > Order and select your order;
8. Check the Items ordered and the totals:

9. Click the Ship button. Items to ship report 6x the bundle product, as expected:

10. Edit the bundle product, set Ship Bundle Items as Separately;
11. Place a new order, repeating the steps 2 to 6;
12. Go to Admin > Sales > Order and select your new order and click the ship button. Items to ship report 36x the simple product, instead of just 12:

Expected result

1. Order should have 6x the bundle product, meaning 12 simple products;
2. Subtotal should be $108.00;
3. The simple product row should show just once;

Actual result

1. Order has 6x the bundle product, but it reports 36x simple product;
2. Subtotal is $324.00;
3. The simple product row shows 3 times;

[m2-assistant]

Hi @kassner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@kassner do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @AlexWorking. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[kassner]

My technical investigation:

When adding the product to the cart the 2nd (and subsequent times), Magento\Quote\Model\Quote\Item::representProduct returns false when iterating over the simple product. Digging a bit further, compareOptions reports false because the bundle_selection_attributes option for the quote_item already persisted contains the price inside:

{"price":"9.0000","qty":2,"option_label":"Option","option_id":"1"}

But, when the new cart item is being compared, the price is the original one:

{"price":10,"qty":2,"option_label":"Option","option_id":"1"}

This happens because Magento\Bundle\Model\Product\Type::_prepareProduct has this piece of code:

/*
 * Create extra attributes that will be converted to product options in order item
 * for selection (not for all bundle)
 */
$price = $product->getPriceModel()
    ->getSelectionFinalTotalPrice($product, $selection, 0, 1);
$attributes = [
    'price' => $price,
    'qty' => $qty,
    'option_label' => $selection->getOption()
        ->getTitle(),
    'option_id' => $selection->getOption()
        ->getId(),
];

$product->getPriceModel()->getSelectionFinalTotalPrice will take care of the tier price, but it's being called with a forced quantity of 1, never triggering our tier price rule, so returning a price different than the one saved in the current quote item in the database. The result of this is having multiple simple products attached to the bundle in the quote_item table:

MySQL [magento]> select item_id, quote_id, created_at, updated_at, product_id, store_id, parent_item_id, sku, name, qty, price, base_price, custom_price from quote_item where quote_id=6;
+---------+----------+---------------------+---------------------+------------+----------+----------------+---------------+-------------+--------+---------+------------+--------------+
| item_id | quote_id | created_at          | updated_at          | product_id | store_id | parent_item_id | sku           | name        | qty    | price   | base_price | custom_price |
+---------+----------+---------------------+---------------------+------------+----------+----------------+---------------+-------------+--------+---------+------------+--------------+
|      22 |        6 | 2019-05-09 12:14:01 | 2019-05-09 12:14:07 |          2 |        1 |           NULL | bundle-simple | Test Bundle | 6.0000 | 54.0000 |    54.0000 |         NULL |
|      23 |        6 | 2019-05-09 12:14:01 | 2019-05-09 12:14:07 |          1 |        1 |             22 | simple        | Simple      | 2.0000 |  9.0000 |     9.0000 |         NULL |
|      24 |        6 | 2019-05-09 12:14:04 | 2019-05-09 12:14:07 |          1 |        1 |             22 | simple        | Simple      | 2.0000 |  9.0000 |     9.0000 |         NULL |
|      25 |        6 | 2019-05-09 12:14:07 | 0000-00-00 00:00:00 |          1 |        1 |             22 | simple        | Simple      | 2.0000 |  9.0000 |     9.0000 |         NULL |
+---------+----------+---------------------+---------------------+------------+----------+----------------+---------------+-------------+--------+---------+------------+--------------+

--

I am not sure why do we store the price there. Just removing the price from the previously mentioned $attributes makes everything working as expected. Is there any reason to have the price there, giving that this same price is stored in the price/base_price column in the quote_item table?

[magento-engcom-team]

✅ Confirmed by @AlexWorking
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99620, MAGETWO-99621 were created

Issue Available: @AlexWorking, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @irajneeshgupta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.