Table structure issue catalog_product_entity (sku field is allowed nulls)

[stephan-cream]

Preconditions (*)

1. Any Magento version (tested on all significant releases, 2.1, 2.2, 2.3)
2. Reproduced on 2.4-develop

Steps to reproduce (*)

1. Add a product either through migration, a custom importer or directly in the database.
2. Leave out the field SKU (in other words, leave it NULL).
3. Go to the product edit page in the backoffice.

Expected result (*)

1. Should not be possible to add the product OR should not throw an error in the backoffice.

Actual result (*)

1. Product is added without issues.
2. When attempting to edit the product in the backoffice the following error is thrown:
   Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Catalog\Model\ProductRepository::prepareSku() must be of the type string, null given, called in /vendor/magento/module-catalog/Model/ProductRepository.php on line 790 and defined in /vendor/magento/module-catalog/Model/ProductRepository.php:800 Stack trace: #0 /vendor/magento/module-catalog/Model/ProductRepository.php(790): Magento\Catalog\Model\ProductRepository->prepareSku(NULL) #1 /vendor/magento/module-catalog/Model/ProductRepository.php(349): Magento\Catalog\Model\ProductRepository->saveProductInLocalCache(Object(Magento\Catalog\Model\Product\Interceptor), '3e07f167255019f...') #2 /vendor/magento/module-catalog/Model/ProductRepository.php(314): Magento\Catalog\Model\ProductRepository->cacheProduct('3e07f167255019f...', Object(Magento\Catalog\Model\Product in /vendor/magento/module-catalog/Model/ProductRepository.php on line 800

[m2-assistant]

Hi @stephan-cream. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@stephan-cream do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[stephan-cream]

I believe this to be a mistake in the structure design, as SKU is required throughout Magento.

[rodrigowebjump]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-27411-2-4-develop.instances.magento-community.engineering/admin_399e
Login: 7deac959 Password: acb0d5600985
Instance will be terminated in up to 3 hours.

[stephan-cream]

This is a database issue, unless you can directly insert the product in the database (or use custom code to import it) without an SKU this is not 'testable' on an Magento github generated development instance.

[Pavel-Fekete]

Reproducible on the latest 2.4-develop
Product is added without issues, even if SKU value is 'NULL'

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.