Closed
Description
This issue is automatically created based on existing pull request: #27617: Cleanup base theme JavaScript modules
Description (*)
Magento 2.4-develop
This PR is a part of my effort to improve Magento 2 frontend performance.
Here I went file by file through the network tab and cleaned-up files that are always loaded by a theme. Changes in this PR include:
responsive.js
is completely removed because no code in its contents seems to be valid anymore. Additionally, because it was defined indeps
you couldn't even create a mixin for it.product-info-additional
can't be found anywhere in the code base so lines 23-33 do nothing.- Both
mageZoom
andmageGallery
cannot be found in the code as well (maybe a leftover from M1?). There ismage.zoom
widget but it doesn't seem to be imported anywhere. .action.toggle.checkout.progress
element doesn't exist in any HTML, PHTML and JS file.checkout-progress-wrapper
does not exist.
theme.js
is cleaned-up:collapsiblecreate
event can't be found in the code base.#store
element is not in the code base.
ie-class-fixer
is adjusted to be a proper AMD module and usesclassList
API which IE11 supports anyway.
Expected behavior (*)
- Regarding
responsive.js
andtheme.js
files nothing should change as code was not applied anyway. - Regarding
ie-class-fixer.js
,ie11
class should be added to the body on IE11.
Benefits
This PR is a part of my effort to improve Magento 2 frontend performance.
Additional information
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
The issue has been fixed in 2.4-develop branchGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 1 Passed. Automatic verification of issue format passedGate 4. Acknowledged. Issue is added to backlog and ready for developmentMay be fixed according to the position in the backlog.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchMajor restrictions or short-term circumventions are required until a fix is available.Has been reviewed and prioritized during Triage with Product Managers
Type
Projects
Status
Done