Skip to content

[Issue] Remove unneccessary overflowed class from minicart sidebar widget #29160

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #28963: Remove unneccessary overflowed class from minicart sidebar widget


Summary (*)

Magento 2.4-develop
After investigating minibasket sidebar widget I've noticed isOverflowed function that applies overflowed class to one of minibasket elements.

Searching further, it seems that the class or even the word overflowed in any case is not used anywhere in magento2 repository.

As I'm seeking any performance improvements for my personal Magento 2 project I thought it will be worth to submit the changes.

Examples (*)

Can't think of any real testing scenarios. All I've done is I've kept adding products to basket to see if it changes at all the look and behaviour of minibasket

Proposed solution

Questions or comments

  • Do I check the checklist below now, later, or wait for some maintainer to check them for me?
  • This may break custom themes that expect overflowed class. However, I believe if custom theme want's this behaviour, then it should extend the JS widget.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CheckoutFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions