Refactor Magento_Indexer module so that the "indexer_reindex_all_invalid" cronjob and "bin/magento indexer:reindex" command use the same code

[hostep]

Summary (*)

This was discovered while working on #29196

The cronjob indexer_reindex_all_invalid (Magento\Indexer\Model\Processor::reindexAllInvalid) and manually executing bin/magento indexer:reindex {all-invalid-indexers} (Magento\Indexer\Console\Command\IndexerReindexCommand::execute) should execute the exact same thing.
Currently both those entry points have separate codebases for executing their logic which can lead to subtle inconsistencies if only one of both codebases are touched.

We should try to refactor the code into one shared codebase for both entry points.

Examples

It looks like this (probably) accidentally happened at least once in MAGETWO-51540

Proposed solution

@rogyar proposed the following solution:

Additionally, I would create a separate service i.e. validateSharedIndex and put the logic of getIndexerIdsBySharedIndex and validateSharedIndex there. So we can reuse the newly created class for the indexer processor and IndexerReindexCommand.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hostep. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-engcom-team]

Hi @hostep. Thank you for your report.
The issue has been fixed in #29196 by @hostep in 2.4-develop branch
Related commit(s):

• f0c645307e031f9c6b8beb31f18c801dc62c02e3
• 07d4ac67ce54e3b4be771f526975819d1d907d8b
• e9359f1ce92b61890df259114325e575c6dd02dd
• 6a58f7ef0cf75b830f7a7c462d8fa7d010de317e
• bc2aab7c2efec20cfdc83c62765da5c380dcb39e
• f9f3725e1326a375cecbd8fd1c70125d35adeaba

The fix will be available with the upcoming 2.4.2 release.