Skip to content

[Issue] Update Curl to respect case-insensitive headers #29524

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #29274: Update Curl to respect case-insensitive headers


According to RFC 2616 header names are case-insensitive: "Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive." - see https://tools.ietf.org/html/rfc2616#section-4.2

The "Set-Cookie" comparison in the current Curl client is case-sensitive and can cause problems with some (rare) HTTP servers.

Preconditions: (*)

Magento 2.4-develop

According to RFC 2616 header names are case-insensitive: "Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive." - see https://tools.ietf.org/html/rfc2616#section-4.2

The "Set-Cookie" comparison in the previous version is case-sensitive and can cause problems with some (rare) HTTP servers.

Related Pull Requests

None

Fixed Issues (if relevant)

Did not create an issue

Steps to reproduce:

  1. Need to become a debugger to check the value on line:
 if ("Set-Cookie" == $name) {
  1. Go to Admin -> Find Partners & Extensions (for example);

Actual Result: ✖️ It doesn't respect those header names ("set-cookie" or "SET-COOKIE")

2020-09-17_09-16

Expected Result: ✔️ It should respect those header names

2020-09-17_09-21
2020-09-17_09-21_1

Questions or comments

Please note that I did not provide a unit test for this specific issue. If required please let me know.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: HTTPFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions