Skip to content

[Issue] Aria-atomic="true" missing on error container #29560

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #27386: Aria-atomic="true" missing on error container


Description (*)

Issue : Aria-atomic="true" is missing on error container

Summary: The page contains an error container made with the WAI-ARIA role="alert" attribute, but it does not contain a WAI-ARIA attribute that will make sure all assistive technology can read the error message after more than one invalid submission.

Fix: To make sure that all assistive technologies will read the error message after more than one invalid submission, added the WAI-ARIA attribute aria-atomic="true" to the error container tag.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Preconditions:

have Cart price rule with discount code;

Steps to reproduce:

  1. Go to Storefront;
  2. Add product to cart;
  3. Go to Shopping Cart;
  4. Expand Apply Discount Code tab and fill correct code

Expected Result: ✔️ The success message is shown on the page

Screenshot from 2020-09-03 11-19-16

  1. Try to fill with incorrect code

Expected Result: ✔️ The error message is shown on the page

Screenshot from 2020-09-03 11-19-06

  1. Proceed to Checkout;
  2. Fill all required fields and go to Review & Payments step;
  3. Expand the Apply Discount Code tab and fill correct code

Expected Result: ✔️ The success message is shown on the page

Screenshot from 2020-09-03 11-13-30

  1. Try to fill with incorrect code

Expected Result: ✔️ The error message is shown on the page

Screenshot from 2020-09-03 11-13-19
Actual Result:

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: SalesRuleComponent: UiFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions