Skip to content

[Issue] Add Event Prefix And Object To The Catalog Product Option Value Collection #29621

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #26401: Add Event Prefix And Object To The Catalog Product Option Value Collection


Preconditions (*)

Magento 2.4-develop

Fixed Issues (if relevant)

n/a

Steps to reproduce: (*)

  1. Try to customize the collection loading of \Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.
  2. Currently, one can only use the generic events like core_collection_abstract_load_before.
  3. With this pull request, one can also use specific events like catalog_product_option_value_collection_load_before.

Actual Result:
✖️ here is no dispatch specially event for loading Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.
Only general core_collection_abstract_load_before was dispatched.

Expected Result:
✔️ here is dispatch general core_collection_abstract_load_before and catalog_product_option_value_collection event for load before(+ _load_before) and after (+ _load_after) for Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.

Questions or comments

Would it make sense to check more relevant Magento core models / collections and add event prefixes / objects there as well?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Fixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions