Skip to content

[Issue] Refactor not needed before and around plugins #29653

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #29518: Refactor not needed before and around plugins


Preconditions (*)

Refactored some parts that using both before and after plugins for save method, also one that uses around.

It's possible to do because of replacing !$object->getId() to $object->isObjectNew() which is true even after saving the model

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Steps to reproduce (*)

Actual Result (*)

Expected Result (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Component: CatalogComponent: CatalogInventoryComponent: CatalogSearchComponent: ThemeFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P2A defect with this priority could have functionality issues which are not to expectations.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions