\Error object not handled properly in numerous areas.

[dfelton]

Preconditions (*)

1. Magento Open Source 2.4-develop

Steps to reproduce (*)

1. Install fresh copy of Magento 2.4-develop
2. Create new module that has an event observer which listens for the cms_page_save_after event. Contents:

<?php

declare(strict_types=1);

namespace VendorName\ModuleName\Observer

class CmsPageSaveAfter
{
    public function execute(Observer $observer)
    {
        if (rand(0, 1)) {
            throw new \Error('this is an instance of \Error and will cause many problems');
        } else {
            $this->causeTypeError(1); // will also break.
        }
    }

    private function causeTypeError(string $foo): void
    {
        // dummy for purposes of reproducing bug
    }
}

3. Log into the admin, open a cms page (or begin creating new page) for editing, make any change, and save page.

Expected result (*)

1. Since \Magento\Cms\Controller\Adminhtml\Page\Save::execute() is written to catch objects of \Throwable, it should pass to \Magento\Framework\Message\ManagerInterface an object that will be accepted.

Actual result (*)

1. The Save controller catches \Throwable, and passes to ManagerInterface::addExceptionMessage() an instance of \Error (or \TypeError, which extends \Error), and since addExceptionMessage() only accepts objects which are an instance of \Exception rather than \Throwable, yet another \TypeError is thrown. This \TypeError trickles up to the catch statement in \Magento\Framework\App\Bootstrap::run() which catches objects of \Throwable, and the application is terminated.

⚠️ Note: Points 1-3 need to be investigated if they are relevant to /Error object before fix

Original expected result:

1. If updating an existing page, \Magento\Framework\EntityManager\Operation\Update::execute() should roll back the mysql transaction
2. If creating a new page, \Magento\Framework\EntityManager\Opteration\Create::execute() should roll back the mysql transaction
3. On the same note, if this were to happen on a entity where it's ResourceModel still performed CRUD operations using \Magento\Framework\Model\ResourceModel\Db\AbstractDb::save(), the transaction should be rolled back here as well.
4. Since \Magento\Cms\Controller\Adminhtml\Page\Save::execute() is written to catch objects of \Throwable, it should pass to \Magento\Framework\Message\ManagerInterface an object that will be accepted.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

Since this requires customization to the application to occur, I will not mark any of the Severity issues, as I have not found any occurrences where this issue is able to be reproduced from native stock code. However, I believe there to clearly be areas in the core code where revisions are appropriate to handle these situations more properly.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @dfelton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-40663 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.