Graphql updateCartItems (removal) not working when stock management and max stock amount reached

[paulappelbe]

Preconditions (*)

1. Magento 2.3
2. using graphql to add/remove products

Steps to reproduce (*)

Say you have 3 products in stock, you add 3 to the cart and try to remove one via the "updateCartItems" graphql, so setting the qty to 2, it refuses to remove because of insufficient stock.
using Luma it works, but not using graphql.

Expected result (*)

1. you should be able to remove the product even if at max amount of stock

Actual result (*)

1. exception happens
   main.ERROR: Could not update cart item: La quantité demandée n’est pas disponible {"exception":" (GraphQL\Error\Error(code: 0): Could not update cart item: La quantité demandée n’est pas disponible at /vendor/magento/module-quote-graph-ql/Model/Resolver/UpdateCartItems.php:92, Magento\Framework\GraphQl\Exception\GraphQlInputException(code: 0): Could not update cart item: La quantité demandée n’est pas disponible at /magento/vendor/magento/module-quote-graph-ql/Model/Cart/UpdateCartItem.php:95)"} []

[m2-assistant]

Hi @paulappelbe. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[fooman]

While likely not the cause of this issue unless custom product options are also used, there is a related issue with stock and grapqhl. Setup a product that uses custom option that importantly changes the SKU.

Then add the product to the cart. This product will always be out of stock because https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Model/Product/Type/AbstractType.php#L802 getSku() will provide the option adjusted sku rather than sku that inventory is based on.

Fix

diff --git a/Model/Resolver/StockStatusProvider.php b/Model/Resolver/StockStatusProvider.php
index 2002adf9..204f9752 100644
--- a/Model/Resolver/StockStatusProvider.php
+++ b/Model/Resolver/StockStatusProvider.php
@@ -55,7 +55,7 @@
         $product = $value['model'];

         $stockId = $this->getStockIdForCurrentWebsite->execute();
-        $result = $this->areProductsSalable->execute([$product->getSku()], $stockId);
+        $result = $this->areProductsSalable->execute([$product->getData('sku')], $stockId);
         $result = current($result);

         return $result->isSalable() ? 'IN_STOCK' : 'OUT_OF_STOCK';

[mmezhensky]

@magento I am working on this