Process Manager doesn't handle exceptions properly in forked processes

[pawel-siejba]

The following bug can have fatal consequences if somebody employed any form of exception handling around indexers in their installation, as it could lead to very hard to discover bugs, that appear only on environments with several threads available, and MAGE_INDEXER_THREADS_COUNT env variable set.

Preconditions (*)

1. Magento 2.3.0 CE/EE or higher
2. Magento 2.4-develop
3. Several stores are active
4. (Optional) Elasticsearch is configured as search_engine - for ease of reproducing

Steps to reproduce (*)

1. Run MAGE_INDEXER_THREADS_COUNT=4 php bin/magento indexer:reindex catalogsearch_fulltext
2. Kill Elasticsearch process to simulate an exception thrown

Expected result (*)

1. Main process exits and the message is displayed only once, the exceptions from the forked processes are not handled as they were thrown in the main process.

Actual result (*)

1. Observe multiple Indexer failure logs and messages

xx@xx:/var/www/magento2$ MAGE_INDEXER_THREADS_COUNT=4 php bin/magento indexer:reindex catalogsearch_fulltext
Catalog Search indexer process unknown error:
Indexer handler is not available: elasticsearch7
Catalog Search indexer process unknown error:
Indexer handler is not available: elasticsearch7
Catalog Search indexer process unknown error:
Indexer handler is not available: elasticsearch7
Catalog Search indexer process unknown error:
Indexer handler is not available: elasticsearch7
Catalog Search indexer process unknown error:
Catalog Search indexer process unknown error:
Catalog Search indexer process unknown error:
Indexer handler is not available: elasticsearch7
Indexer handler is not available: elasticsearch7
Indexer handler is not available: elasticsearch7
Catalog Search indexer process unknown error:
Fail in child process

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @pawel-siejba. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[pawel-siejba]

@magento I am working on this

[m2-assistant]

Hi @pawel-siejba! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[pawel-siejba]

@magento add to contributors team

[m2-assistant]

Hi @pawel-siejba! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[pawel-siejba]

@magento add to contributors team

[pawel-siejba]

@magento I am working on this