Region field visible for Country when "Allow to Choose State if It is Optional for Country" is disabled

[mweiss-quotient]

Preconditions (*)

1. Magento 2.4.1 and 2.4-develop
2. PHP 7.4

Steps to reproduce (*)

1. In General Settings configure Default Country that doesn't support States (eg. Czech Republic)
2. In General Settings configure Allowed countries same as Default Country
3. Make sure that your Default Country isn't selected in State is Required for field
4. In General Settings configure Allow to Choose State if It is Optional for Country to NO
5. Navigate to storefront as a guest and add product to cart.
6. Go to Checkout page.

Expected result (*)

1. Default Country is automatically selected in shipping address form and region field is hidden.

Actual result (*)

1. Default Country is automatically selected in shipping address form but region input field is visible.

Additional info from Engcom

According to the documentation, when Allow to Choose State if It is Optional for Country is set to No - In countries where the state field is not required, omits the State field.

1. In General Settings set country that doesn't support States for Default Country and Allowed countries settings (eg. Czech Republic)
   
2. Make sure that your Default Country isn't selected in State is Required for field
   
3. In General Settings set Allow to Choose State if It is Optional for Country to NO
   
4. Navigate to storefront as a guest and add product to cart.
5. Go to Checkout page.

Actual result
Default Country is automatically selected in shipping address form but region input field is visible.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[mweiss-quotient]

I have hot-fixed this issue by adding following method to app/code/Magento/Ui/view/base/web/js/form/element/region.js:

filter: function (value, field) {
            var superFn = this._super;
            superFn.call(this, value, field);
            
            var option = _.isObject(this.countryOptions) && this.countryOptions[value];

            if (option && option['is_region_visible'] === false) {
                // hide select and corresponding text input field if region must not be shown for selected country
                this.setVisible(false);

                if (this.customEntry) {// eslint-disable-line max-depth
                    this.toggleInput(false);
                }
            }
}

Similar method was present in region.js in Magento 2.3.5-p2:
https://github.com/magento/magento2/blob/2.3.5-p2/app/code/Magento/Ui/view/base/web/js/form/element/region.js#L80

[magento-engcom-team]

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38833 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.