Skip to content

[Issue] Update sortOrder load for async css plugin #30882

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #30871: Update sortOrder load for async css plugin


Description (*)

Magento 2.4-develop
This update made for sure load async css plugin first before JsFooterPlugin load. We use lower order for let magento run AsyncCssPlugin first then run into JsFooterPlugin. After all that is cache plugins will be run

Before this PR
Order plugins
JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache) < AsyncCssPlugin

After this PR
Order plugins now will be
AsyncCssPlugin < JsFooterPlugin < BuiltinPlugin(PageCache) < VarnishPlugin(PageCache)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Setup site magento 2.4 with code base 2.4-develop
  2. Cache types all enabled
  3. Enable async css
    Stores > Configuration > Advanced > Developer > Css setttings > Use CSS critical path: YES
  4. Clear cache page + config

Questions or comments

CC: @HenKun @sidolov @krzksz @brightonmike Feel free give to me any suggest or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Component: ThemeIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S1Affects critical data or functionality and forces users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions