Some strings not translatable in M2.4.1

[siimm]

Preconditions (*)

1. Clean Magento 2.4.1 installation
2. 2.4-develop

Steps to reproduce (*)

1. Add a product to cart
2. Navigate to cart page
3. Open admin interface, find the product, save it as "Out of Stock"
4. Refresh cart page, see error message: There are no source items with the in stock status
5. Find the translation for the message in vendor/magento/module-catalog-inventory/i18n/en_US.csv
6. Change the result string to be something else
7. Clean "translate" cache
8. Refresh the cart page and witness the previously mentioned string being not translated to value we changed it at point 6

Expected result (*)

1. Error messages are translated

Actual result (*)

1. Error messages are not translated - can be verified even with default en_US language - change the translation for the error message

NOTES

The steps to reproduce part only highlights one specific string, however this seems to be a more general problem:

Due to update of design (and translations) loading in b2a035d
(loading design and translations was moved from beforeDispatch to beforeExecute)

However there are several plugins in M2 ecosystem, which come before actual execute call, \Magento\InventorySales\Model\IsProductSalableForRequestedQtyCondition\IsProductSalableForRequestedQtyConditionChain is one of the many examples (on quote loading, validation is triggered).

Verified this in clean Magento 2.4.1 - the error phrase is never translated, as renderers for Phrase is set only in \Magento\Theme\Plugin\LoadDesignPlugin::beforeExecute

This happens due to renderer not being set to \Magento\Framework\Phrase, and if it is used earlier than the renderers are set - the original string gets returned, as it uses the RendererPlaceholder class to render them.

With current state, a lot of strings cannot be translated, the only imaginable workaround is to move design and translations loading back to beforeDispatch method. (Moving just the translation loading to beforeDispatch won't help, if the translations are in theme.)

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• < ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @siimm. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@sidolov @gabrieldagama, I believe this is a significant issue. Could you take a look at it and set priority on it?
/CC @lbajsarowicz note seems like changes from #26778 caused this issue.

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Alfa]

@siimm .
We are able to reproduce this issue on clean Magento 2.4-develop + Inventory

Manual testing scenario:

1. Add a product to cart
2. Navigate to cart page
3. Open admin interface, find the product, save it as "Out of Stock"
4. Refresh cart page, see error message: There are no source items with the in stock status
5. Find the translation for the message in vendor/magento/module-catalog-inventory/i18n/en_US.csv
6. Change the result string to be something else
7. Clean "translate" cache
8. Refresh the cart page and witness the previously mentioned string being not translated to value we changed it at point 6

Actual Result: ✖️ Error messages are not translated

but we are not able to reproduce it on clean Magento 2.4-develop:

Manual testing scenario:

1. Add a product to cart
2. Navigate to cart page
3. Open admin interface, find the product, save it as "Out of Stock"
4. Refresh cart page, see error message: This product is out of stock
5. Find the translation for the message in vendor/magento/module-catalog-inventory/i18n/en_US.csv
6. Change the result string to be something else
7. Clean "translate" cache
8. Refresh the cart page and witness the previously mentioned string being not translated to value we changed it at point 6

Actual Result: ✔️ Error messages are translated

@siimm @ihor-sviziev Can we assume that the root of the problem is in the Inventory? Is this problem not related to MSI?
Thanks!

[siimm]

hi @engcom-Alfa

The inventory message served as an example, what I wanted to highlight was a more general problem with the architectural design of the current solution.
I am convinced that if I go looking for next examples, I will find them.

A brief look into predispatch plugins already reveals bunch of points to check, not speaking of classes which are used in those plugins that also have translations.

Siims-MBP :: m2clean/vendor/magento » grep -l -r "n beforeDispatch" .|xargs grep "__("
./module-invitation/Controller/Customer/Account/Plugin.php:            throw new NotFoundException(__('Page not found.'));
./module-wishlist/Controller/Index/Plugin.php:                $this->messageManager->addErrorMessage(__('You must login or register to add items to your wishlist.'));
./module-wishlist/Controller/Index/Plugin.php:            throw new NotFoundException(__('Page not found.'));
./module-multiple-wishlist/Controller/Index/Plugin.php:            throw new NotFoundException(__('Page not found.'));
./module-store/App/Action/Plugin/Context.php:                ? __($previousException->getMessage())
./module-store/App/Action/Plugin/Context.php:                : __('Invalid store requested.'),
./module-deploy/Model/Plugin/ConfigChangeDetector.php:                __(

If you would like, I can come up with next set of examples.

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40654 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.