Upgrade Issue, While upgrade from Magento 2.4.2-p1 to Magento 2.4.3

[arjunadobe]

Preconditions (*)

1. Magento 2.4.3 (EE)
2. Composer 2

Steps to reproduce (*)

Hi,

I am upgrading from Magento 2.4.2-p1 from Magento 2.4.3. Composer Update was working fine, but when I tried to run

php bin/magento setup:upgrade

I am getting the below error.

Unable to apply data patch Magento\Paypal\Setup\Patch\Data\UpdateBmltoPayLater for module Magento_Paypal. Original exception message: Notice: Undefined offset: 1 in vendor/magento/module-paypal/Setup/Patch/Data/UpdateBmltoPayLater.php on line 138
When I checked the code, I found out we didn't check whether the value is exploadable in some scenarios like this

path => payment/paypal_express_bml/active , value => 0

and it's throwing the error in this line

$page = $settingParts[0]; $setting = $settingParts[1];

Expected result (*)

While Setup:upgrade it should work fine

Actual result (*)

Module 'Magento_Paypal': Unable to apply data patch Magento\Paypal\Setup\Patch\Data\UpdateBmltoPayLater for module Magento_Paypal. Original exception message: Notice: Undefined offset: 1 in vendor/magento/module-paypal/Setup/Patch/Data/UpdateBmltoPayLater.php on line 138

Fix for this :
Add if(strpos($setting, '_') == false) { continue }

foreach ($bmlSettings as $bmlPath => $bmlValue) { $setting = str_replace(self::BMLPATH, '', $bmlPath); if(strpos($setting, '_') == false) { continue; }

[m2-assistant]

Hi @arjunadobe. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ericclaeren]

Yes, can confirm this issue. I had to remove config value.

DELETE FROM `core_config_data` WHERE `path` = 'payment/paypal_express_bml/active'; 

To get setup:upgrade to run.

[arjunadobe]

Yes, can confirm this issue. I had to remove config values

DELETE FROM `core_config_data` WHERE `path` IN ('payment/paypal_express_bml/active', 'payment/paypal_express_bml/publisher_id'); 

To get setup:upgrade to run.

DELETE FROM core_config_data WHERE path="payment/paypal_express_bml/active";

This is enough

[ericclaeren]

Yes @arjunadobe, thanks, you're absolutely right!

[EmperorKonstantin]

@ericclaeren Can you let me know how you diagnosed this bug?

[fascinosum]

@magento export issue to Jira project AC as Bug

[fascinosum]

hi @arjunadobe,
thank you for reporting this issue.
The internal team will work to fix this, internal Jira ticket linked to the GitHub issue, and the status will be updated accordingly

@ericclaeren thank you for the workaround

[ericclaeren]

@ericclaeren Can you let me know how you diagnosed this bug?

I have upgraded a Adobe Commerce (F.K.A Magento EE) from version 2.3.5-p1 to 2.4.3. And got stuck during setup upgrade.