Magento 2.4.2 to 2.4.3 Upgrade Issue use php 8 function

[magedevel]

Preconditions (*)

1. Try to upgrade from version 2.4.2-p1 to 2.4.3
2. MSI modules are disabled using a replace on composer.

Steps to reproduce (*)

1. execute: composer require magento/product-community-edition=2.4.3 --no-update
2. execute : composer update

Expected result (*)

1. Magento was updated to version 2.4.3

Actual result (*)

1. Has got an error :
   Fatal error: Uncaught Error: Call to undefined function Magento\Framework\Filesystem\Directory\str_contains() in /var/www/html/vendor/magento/framework/Filesystem/Directory/DenyListPathValidator.php:74
   Class \Magento\Framework\Filesystem\Directory\DenyListPathValidator use a PHP 8.0 function. (str_contains)

....
foreach ($this->fileDenyList as $file) {
            $baseName = pathinfo($actualPath, PATHINFO_BASENAME);
            if (str_contains($baseName, $file) || preg_match('#' . "\." . $file . '#', $fullPath)) {
                throw new ValidatorException(
                    new Phrase('"%1" is not a valid file path', [$path])
                );
            }
        }

Notes

Based on requirement this version should work on PHP 7.4
https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements.html

And in the release note (https://devdocs.magento.com/guides/v2.4/release-notes/open-source-2-4-3.html) you wrote:
Magento 2.4.3 is not yet compatible with PHP 8.x, but the following platform upgrades bring us closer to future compatibility with PHP 8.x.

[m2-assistant]

Hi @magedevel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

Is a duplicate of #33680, hopefully this comment can help you further

[magedevel]

I can confirm that the work around works.

[m2-assistant]

Hi @ihor-sviziev. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[ihor-sviziev]

Hi @magedevel,
I'm closing this issue as duplicate of #33680

[sidolov]

Hi @magedevel. Thank you for your report.
The issue has been fixed in #33886 by @reense in 2.4-develop branch
Related commit(s):

• 055d9fc3702095a356806f23451ae084cf724fc4
• 5888eea95fb19c980d604c98886a41077cf5c75b
• cda98b598210c3e31ae6f792488a089f300b1c0b
• b72097df62a6db2b204a6c9fe4f7647a3eb80832

The fix will be available with the upcoming release.