Unable to remove parameter override for a webapi route

[gowrizrh]

I stumbled upon the necessity to remove a parameter override which is defined in a webapi.xml

<route url="/V1/customers" method="POST">
    <data>
        <parameter name="customer.extension_attributes.company_attributes.company_id" force="true">%company_id%</parameter>
    </data>
</route>

My initial though was setting force="false" should remove the paramter being overwritten by the \Magento\Framework\Webapi\Rest\Request\ParamOverriderInterface, however that was not the case.

Upon closer look into the schema converter \Magento\Webapi\Model\Config\Converter that's responsible to read the xml files I found out the line that's responsible to parse the attribute is incorrect.

$force = $forceNode ? (bool)$forceNode->nodeValue : false;

Strings always evaluate to boolean true unless they have a value that's considered "empty" by PHP. PHP empty documentation

1. ""
2. "0"

Current work around is setting a falsy value so that works

<route url="/V1/customers" method="POST">
    <data>
        <parameter name="customer.extension_attributes.company_attributes.company_id" force="0">%company_id%</parameter>
    </data>
</route>

Preconditions (*)

1. vanilla Magento 2.4.3

Steps to reproduce (*)

1. Define an existing or new webapi route paramter override with force="false"

Expected result (*)

1. The parameter override should have the value set to false

Using n98 to inspect (Magento\Webapi\Model\ConfigInterface::getServices()['routes']['V1/customers'])

[
    "POST" => [
        "secure" => false,
        "service" => [
            "class" => "Magento\Customer\Api\AccountManagementInterface",
            "method" => "createAccount",
        ],
        "resources" => [
            "anonymous" => true,
        ],
        "parameters" => [
            "customer.extension_attributes.company_attributes.company_id" => [
                "force" => false,
                "value" => "%company_id%",
            ],
        ],
    ],
]

Actual result (*)

1. The paramter override still has the value true

Using n98 to inspect

[
    "POST" => [
        "secure" => false,
        "service" => [
            "class" => "Magento\Customer\Api\AccountManagementInterface",
            "method" => "createAccount",
        ],
        "resources" => [
            "anonymous" => true,
        ],
        "parameters" => [
            "customer.extension_attributes.company_attributes.company_id" => [
                "force" => true, # this is still true
                "value" => "%company_id%",
            ],
        ],
    ],
]

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @gowrizrh. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gowrizrh]

@magento I am working on this

[gowrizrh]

I will create a PR to fix this.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.