Cannot place order at checkout with Braintree and 3DS enabled using billing addresses without region set

[dphilipps]

Preconditions (*)

1. Magento 2.4.3
2. Braintree enabled
3. Card Payments enabled
4. 3D Secure enabled
5. Use billing address without state/region set

Steps to reproduce (*)

1. Enable Braintree in Sandbox mode.
2. Sandbox credentials:
   PUBLIC: hpbfzdqypph3njjq
   PRIVATE: 4de9983821adb24738636e502c557248
   MERCHANTID: vq82jrtv65hsgjbk
3. Enable Braintree Card Payments
4. Enable Braintree 3D Secure
5. Sign in to front end as demo user
6. Under account edit default address and ensure set as default shipping and billing
7. Country: United Kingdom
8. Street address: 123 Somewhere
9. City: London
10. State/Province: [MUST BE LEFT EMPTY]
11. Postcode: SE3 9SZ
12. Make up any other address details
13. Save address
14. Add a product to basket and proceed to payment step
15. Select credit card
16. Enter card details:
    4242 4242 4242 4242
    12/23
    123
17. Click 'Place Order'

Expected result (*)

1. Order confirmation is displayed

Actual result (*)

1. Cannot proceed past payment screen and cannot place order. Button is non responsive and no errors are displayed on screen. Console messages below:

Note: If 3DS is disabled, then the same address (above) will complete OK. Likewise, if a state/region is set it will too.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• [ X] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

3DS is vital for processing credit card payments as is a regulatory requirement in some jurisdictions and some processors do not approve payments without, therefore disabling it is not a work around. UK addresses which typically do not have state or region set will not be able to place orders with 3DS enabled.

[m2-assistant]

Hi @dphilipps. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[dphilipps]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @dphilipps. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @dphilipps, here is your Magento Instance: https://2e0e748fe9adb6f5da4bafbe39d78c0c-2-4-develop.instances.magento-community.engineering
Admin access: https://2e0e748fe9adb6f5da4bafbe39d78c0c-2-4-develop.instances.magento-community.engineering/admin_dbfb
Login: 8f213e7d
Password: c6d8bb5f8e82

[dphilipps]

Hi @engcom-November
How do i get an instance deployed with Braintree included in the build? Even with country set in payment methods config, it does not appear.

Many thanks
Dave

[dphilipps]

I have verified these steps on a fresh composer install of M2.4.3

[dphilipps]

What do I need to add to this ticket to get it to be triaged @magento/engcom-team-members? This is a serious checkout issue in the latest version of Magento using a mainstream payment gateway?

[nicholasscottfish]

Is there any update on this, we are also experiencing the same issue. This is a critical bug and needs addressing, happy to assist with a fix if required.

@dphilipps did you happen to find a workaround? Disabling 3DS is a no-go for legal reasons, yet making the state field required is a UX problem.

[nicholasscottfish]

@dphilipps For all those who come across this issue, I have created a patch file, attached.

ISSUE-34204__PayPal-Braintree-Validation.patch.zip

diff --git a/view/frontend/web/js/view/payment/3d-secure.js b/view/frontend/web/js/view/payment/3d-secure.js
index 864d5e53..ef832923 100644
--- a/view/frontend/web/js/view/payment/3d-secure.js
+++ b/view/frontend/web/js/view/payment/3d-secure.js
@@ -55,7 +55,7 @@ define([
                 totalAmount = parseFloat(quote.totals()['base_grand_total']).toFixed(2),
                 billingAddress = quote.billingAddress();

-            if (billingAddress.regionCode !== undefined && billingAddress.regionCode.length > 2) {
+            if (billingAddress.regionCode != null && billingAddress.regionCode.length > 2) {
                 billingAddress.regionCode = undefined;
             }

This patch file updates the validation to check for null, which naturally covers both 'undefined and null', thus bypassing the 'cannot read properties of null' error when reading the length in the case a region is not set.

I have created a PR on the Braintree repo, is this the correct place for it? If I need to raise a PR on a different repo please may somebody assign the issue to me and point me in the right direction.

genecommerce/module-braintree-magento2#182

I would question the original code as it seems a bit of a hack having to set regionCode to undefined, a possible workaround for a bug in the system at Braintree's end?

[dphilipps]

Hi @nicholasscottfish
Agree this is a nasty one - checkout just freezes. In the end I contacted Gene directly through their Braintree Magento support channel. They got back to me with a patch yesterday but I haven't had a chance to test it yet. I'll post it here. Thanks for your patch BTW.

[dphilipps]

Patch supplied by Gene support directly in response to this issue, however I have not tested it yet.

when region-code is not mandatory(for Magento 2.4.3).zip

[nicholasscottfish]

Hi @dphilipps, the patch I posted has been tested and fixes the issue, however, looking at the patch they supplied it is fixing the same lines of code but is slightly different in that they still set regionCode as undefined if it was null, possibly what needs to happen.

I will get in touch to find out why that is necessary.

Thanks for sharing!