Knockout not translateable with text contain single quote character

[mrtuvn]

Summary (*)

Examples (*)

Example this text italiano
se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato

As you can see text contain one single quote
if we use translate attribute will not work. Same for data-bind

Change text (remove quote) will be workarounds but it's may not be option when sometimes we want keep remain text

Example

<span translate="'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

or

<span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

Proposed solution

Additional Information

Steps to reproduce

1. Add below line in app/code/Magento/Checkout/view/frontend/web/template/onepage.html:
   <span data-bind="i18n: 'se hai scelto il ritiro dell'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>
2. Add translation in app/code/Magento/Checkout/i18n/en_US.csv
3. Check the checkout page, if we do not escape single quote, then there is an error in the console like below:
   

If we escape the single quote, we are not getting any error but the translation is not working, please have a look into the below screenshot:

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @mrtuvn. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@mrtuvn, I guess it should be escaped, example:

<span translate="'se hai scelto il ritiro dell\'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

and

<span data-bind="i18n: 'se hai scelto il ritiro dell\'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato'"></span>

[mrtuvn]

Yes your way work but seem text still not able to translate

Before following ihor way
Error visible

After apply escape
Error gone but text still not able translate

[ihor-sviziev]

ok. Could you provide some steps to reproduce?

[mrtuvn]

i think this easy to reproduce add this text bind above + your escape approach in any html file . Example file onepage.html of checkout and reload. Also add text translate to csv too.

[mrtuvn]

"se hai scelto il ritiro dell\'usato, ricordati di preparare il vecchio prodotto scollegato e disinstallato","Test text should be translated"

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @mrtuvn,

Thanks for posting this issue!

The issue is reproducible so we are confirming the issue and also I am updating the main description with some more information.

Thanks