Remote storage sync fails on similar image filenames (with hyphens and underscores)

[lphilippo]

Preconditions (*)

1. Magento 2.4.3 CE
2. Activate remote storage with AWS S3

Steps to reproduce (*)

1. Use an image where the filename has an hyphen as a second character: 5-100.png
2. Use a second image with the same first character, but an underscore as second: 5_100.png
3. Synchronise remote storage with bin/magento remote-storage:sync

Expected result (*)

1. Both images will be synchronised with the remote storage.

Actual result (*)

1. The first image (with dash) is being stored correctly.
2. The second image fails with the message Notice: Undefined index: media/catalog/product/5/_ in /src/vendor/magento/module-remote-storage/Driver/Adapter/Cache/Generic.php on line 197
3. The sync process halts.

Technical background

The issue lies in RemoteStorage/Driver/Adapter/Cache/Generic. The dashes are converted to underscore in the internal workings of the cache adapter (line 192). This causes that the underscore variant receives the cache that the dash variant has already created. However, the path inside the $meta has been unaffected by the underscore conversion and the mismatch triggers the exceptions. This was very easily circumvented by the following change to check both non-empty content as well as existence, which prevents that the incorrect cache is being used for the underscore variant:

<             if (!$meta[$path]) {
---
>             if (empty($meta[$path])) {

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

Additional Info

[X] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.

[m2-assistant]

Hi @lphilippo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @lphilippo,

Thanks for reporting the issue!

Hence the issue is reproducible with the given steps, we are confirming this issue. We are getting the below error while running bin/magento remote-storage:sync command:

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-1486 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.