Skip to content

[Issue] Resolve height modal issue on iOS #34467

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #34290: Resolve height modal issue on iOS


Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices)
If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate!
Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom)
defect

After apply fix: (Now button can click and content form still able scroll)
Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually
after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Test case 1

  1. Add product to cart and Goto checkout via mobile
  2. Click on minicart icon to trigger modal
  3. Previously (Modal have scroll for both header and footer) -> Now only modal content scroll, header and footer of modal stay still in user device viewport

Test case 2
Add custom modal form with long content enough (like image in above description)
Active modal and go to mobile screen to visible

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: Cart & CheckoutComponent: CheckoutIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions