Favicon Icon upload form in Magento does not actually support .ico file types

[ksenia-zlotin]

When attempting to upload a favicon file of .ico extension type in Magento admin, Magento will not deem the file as valid.
Tested on a clean composer install of Magento 2.4.3-p1 with a PHP version of 7.4.13.

Perhaps the usage of PHP's imagecreatefromstring causes for an .ico file type to always be deemed invalid by Magento. The exception is thrown: "Warning: imagecreatefromstring(): one parameter to a memory allocation multiplication is negative or zero, failing operation gracefully
in /var/www/html/vendor/magento/module-media-storage/Model/File/Validator/Image.php on line 64"

Preconditions (*)

1. Unaltered, clean install of Magento version 2.4.3-p1
2. PHP version 7.4.13
3. DBMS: MySQL (ver. 5.5.5-10.2.40-MariaDB-1:10.2.40+maria~bionic)
   Case sensitivity: plain=exact, delimited=exact
   Driver: MySQL Connector/J (ver. mysql-connector-java-8.0.25 (Revision: 08be9e9b4cba6aa115f9b27b215887af40b159e0), JDBC4.2)
   Effective version: MariaDB (ver. 10.2.40)
4. Chrome browser version Version 96.0.4664.110 (Official Build) (x86_64)
5. MacBook Pro - OS: Catalina 10.15.7

Steps to reproduce (*)

1. Login to Magento admin
2. Navigate to Content -> Design -> Configuration
3. Click 'Edit' on any of the records shown in the grid
4. Scroll to 'Other Settings'
5. Expand 'HTML Head'
6. Under the 'Favicon Icon' section, click 'Upload'
7. Select a valid .ico file, click 'Open'

Expected result (*)

1. It should provide a preview of the icon below the upload form and allow for the admin user to save the configuration settings.

Actual result (*)

1. An error was shown to the admin:
   

[m2-assistant]

Hi @ksenia-zlotin. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hi @ksenia-zlotin,
Thank you for reporting the issue.
We have tried this issue on Magento 2.4-develop and we have successfully reproduced it. Magento is not accepting the “.ico” extension files for the favicon icon event the ".ico" extension is in the allowed extension list.
Steps followed to reproduce issue:

1. log in to Magento admin
2. Navigate to Content -> Design -> Configuration
3. Click 'Edit' on any of the records shown in the grid
4. Scroll to 'Other Settings'
5. Expand 'HTML Head'
6. Under the 'Favicon Icon' section, click 'Upload'
7. Select a valid “.ico” extension file, click 'Open'
8. Observe the upload result (see the attached screenshots).
   
   

Hence confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-2042 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[mmezhensky]

@magento I am working on this