Skip to content

[Issue] Update indexer:reset to call $indexer->invalidate() #34988

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #34582: Update indexer:reset to call $indexer->invalidate()


I was recently debugging something that was invalidating the indexers.

I added some logging using a before plugin on the invalidate function

public function beforeInvalidate(\Magento\Framework\Indexer\IndexerInterface $subject)
{
    $this->logger->info(
        "Invalidating index",
        [
            'indexer_id' => $subject->getId(),
            'trace' => str_replace(PHP_EOL, '|', (new \Exception())->getTraceAsString())
        ]
    );
}

But this use case isn't caught in my logs.

It seems to me that this command should just call the function that invalidates the indexer rather than repeating the work itself. I'm sorting out my own logging / debugging internally, but this seems sensible to fix here.

/**
* Set indexer invalid
*
* @return void
*/
public function invalidate()
{
$state = $this->getState();
$state->setStatus(StateInterface::STATUS_INVALID);
$state->save();
}

Manual testing scenarios (*)

  1. Call indexer:reset and see the indexer was invalidated

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: FrameworkIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions