Skip to content

Fixes #12584 #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixes #12584 #12586

wants to merge 2 commits into from

Conversation

AntonEvers
Copy link
Contributor

Description

Bundle Item prices are missing their website id which is checked for in \Magento\Bundle\Model\Selection::afterSave. This check always failed.

Fixed Issues (if relevant)

  1. Bundle Item price cannot differ per website #12584: Bundle Item price cannot differ per website

Manual testing scenarios

  1. see the scenario in Bundle Item price cannot differ per website #12584

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Website id is checked for but is not added to bundle option prices
@ishakhsuvarov
Copy link
Contributor

Hi @ajpevers
Thank you for contribution.
I think this this fix needs some tests to make sure it is not broken in the future.

@AntonEvers
Copy link
Contributor Author

@ishakhsuvarov you're absolutely right. I'll look into it.

@ishakhsuvarov
Copy link
Contributor

@ajpevers Thanks. Please let us know if you need any help.

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 8, 2017
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 1, 2018
@magento-engcom-team
Copy link
Contributor

@ajpevers thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov
Copy link
Contributor

sidolov commented Mar 1, 2018

Fixed test failures

@sidolov
Copy link
Contributor

sidolov commented Mar 2, 2018

Hi @ajpevers , our QA report a problem with the current solution:
Steps to reproduce:

  1. Set Stores -> Configuration -> Catalog -> Catalog -> Price -> Catalog Price Scope to 'Website'
  2. Create a second website, store and store view
  3. Create a bundle product with option 'Dynamic Price': 'No'
  4. Add it to both websites
  5. Add a bundle item with price type 'fixed' and price '12'
  6. Save the product
  7. Use the dropdown on the top left to change scope to your second store view
  8. Set the Bundle Item price to '10'
  9. Save the product.

Expected result:
The bundle item should have price '12' in the default scope and '10' in the second store view.

Actual result:
The bundle item has price '10' everywhere

  1. Use the dropdown on the top left to change scope to your default store view.
  2. Set the Bundle Item price to '12'
  3. Save the product.

Expected result:
The bundle item have price '12' in the default scope and '10' in the second store view

Actual result:
The bundle item have price '12' in the default scope and '10' in the second store view

So, we need to save product with the same price twice in default scope for expected behavior.

@sidolov
Copy link
Contributor

sidolov commented Mar 16, 2018

@ajpevers , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants