[Children Ids] #184 - Create a cache to store children ids

[PierreLeMaguer]

Fixed Issues (if relevant)

magento/community-features#183: Improve the performance of the method app/code/Magento/Eav/Model/Config.php::getAttribute

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @PierreLeMaguer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[kandy]

All new property must be private

[kandy]

PR is adding cache, but missed the cache cleanup that will cause issue

[sidolov]

@PierreLeMaguer , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @PierreLeMaguer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @PierreLeMaguer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[romainruaud]

I'm reopening this PR (sorry if I'm exceeding my rights on this repository).

@sidolov @kandy can you give us clear directives about what needs to be changed / remain to be done ?

regards

[sidolov]

@romainruaud , please, make protected $_cacheChildrenIds = []; as private, try to avoid underscores in property name. That's it

[PierreLeMaguer]

Hi @sidolov , the protected property is needed to use it in all child classes.

[sidolov]

@PierreLeMaguer , please, define private property in the each product type class instead of protected. Also, please, sign CLA, otherwise we cannot proceed with the pull request. Thank you.

[PierreLeMaguer]

Hi @sidolov , I changed the property for a private property.
Can you give us the next steps ?
Thanks

[sidolov]

@PierreLeMaguer please, take a look at failed tests, looks like the solution caused the behavior change

[sidolov]

@PierreLeMaguer I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @PierreLeMaguer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.