Extend password reset token validity on password change page load

[fredden]

Description (*)

This avoids a race condition where the password reset token is valid at page load time, but no longer valid at page submission time.

In a scenario where a user begins the password reset flow but is unable to immediately complete the same, clicking the link close to expiry time provides an opportunity for an error message after entering a new password due to the token expiring between page load & form submission.

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Generate password reset email (admin & frontend)
2. Follow link back to Magento
3. Observe password validity in database has been extended/reset

Questions or comments

I am unsure if this change requires a unit test.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Extend password reset token validity on password change page load #29647: Extend password reset token validity on password change page load

[m2-assistant]

Hi @fredden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

@magento create issue

[ihor-sviziev]

Hi @fredden,
I'm really sorry for long delay with processing your PR. I'll take it and will try to push it forward.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests EE, WebAPI Tests

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests CE

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8461 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Before:
❌ Value in rp_token_created_at column is not changed after customer open a Set a New Password link from reset password email

After:
✔️ Value in rp_token_created_at column is updated and is equal to the time when customer open a Set a New Password link from reset password email

[engcom-Delta]

Note: Automation tests are passed

[korostii]

@magento-engcom-team Any progress update here please?

[m2-assistant]

Hi @fredden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.