Skip to content

Fix #26080 #26081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

korostii
Copy link
Contributor

@korostii korostii commented Dec 17, 2019

Description (*)

Magento_Amqp module relies on a di.xml entry from Magento_MessageQueue module but does not declare this dependency via module.xml. As a result, you can disable Magento_MessageQueue module during Magento setup/install but you will get the following error:

PHP Fatal error:  Uncaught Error: Cannot instantiate interface Magento\Framework\MessageQueue\ConfigInterface in /var/www/magento2/magento2/lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php:121

This PR fixes such an issue by moving the corresponding di.xml entry to the global app/etc/di.xml since it actually only involves two framework classes anyway.

Fixed Issues (if relevant)

  1. [2.4-develop] Cannot instantiate Magento\Framework\MessageQueue\ConfigInterface if optional module Magento_MessageQueue is disabled #26080: [2.4-develop] Cannot instantiate Magento\Framework\MessageQueue\ConfigInterface if optional module Magento_MessageQueue is disabled

Manual testing scenarios (*)

See #26080 for detailed steps

Questions or comments

See #26080 for suggested alternative solutions

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2019

Hi @korostii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@korostii
Copy link
Contributor Author

korostii commented Jul 9, 2020

Any feedback on this? @paliarush @rganin @tariqjawed83 @magento-engcom-team

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8050 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Try to install 2.4-develop with disabled Magento_MessageQueue module
    ( --disable-modules=Magento_MessageQueue)

Before: ✖️ Fatal Error message

Screenshot from 2020-08-21 11-54-34

After: ✔️ The Magento was successfully installed

Screenshot from 2020-08-21 12-00-10

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @korostii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Community Insider: Magecom community-insider-contribution Component: MessageQueue Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants