-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #26080 #26081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #26080 #26081
Conversation
Hi @korostii. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Any feedback on this? @paliarush @rganin @tariqjawed83 @magento-engcom-team |
Hi @sidolov, thank you for the review. |
@magento run all tests |
Hi @korostii, thank you for your contribution! |
Description (*)
Magento_Amqp
module relies on adi.xml
entry fromMagento_MessageQueue
module but does not declare this dependency viamodule.xml
. As a result, you can disableMagento_MessageQueue
module during Magento setup/install but you will get the following error:This PR fixes such an issue by moving the corresponding
di.xml
entry to the globalapp/etc/di.xml
since it actually only involves two framework classes anyway.Fixed Issues (if relevant)
Manual testing scenarios (*)
See #26080 for detailed steps
Questions or comments
See #26080 for suggested alternative solutions
Contribution checklist (*)