Add Event Prefix And Object To The Catalog Product Option Value Collection

[sprankhub]

Description (*)

This pull request adds an event prefix and event object to the catalog product option value collection, so that it can be customized in a better way.

Fixed Issues (if relevant)

n/a

Manual testing scenarios (*)

1. Try to customize the collection loading of \Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.
2. Currently, one can only use the generic events like core_collection_abstract_load_before.
3. With this pull request, one can also use specific events like catalog_product_option_value_collection_load_before.

Questions or comments

Would it make sense to check more relevant Magento core models / collections and add event prefixes / objects there as well?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Add Event Prefix And Object To The Catalog Product Option Value Collection #29621: Add Event Prefix And Object To The Catalog Product Option Value Collection

[m2-assistant]

Hi @sprankhub. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sprankhub]

@akaplya could you have a look here? Thanks :-)

[sidolov]

@magento create issue

[sidolov]

Risk: high since someone can observe core_collection_abstract_load_before event and expect app/code/Magento/Catalog/Model/ResourceModel/Product/Option/Value/Collection but after the fix the event mmname will be changed.

[sprankhub]

I do not see high risk here, @sidolov. After the change, two events will be dispatched: core_collection_abstract_load_before (same as currently!) plus the new catalog_product_option_value_collection_load_before. So we solely add a new event here.

[sidolov]

@sprankhub thank you for the clarification! I have changed the risk label!

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8295 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Bravo]

Dev experience is required for testing this PR. Please note that Manual testing has not been performed.

[engcom-Charlie]

✔️ QA Passed
Before:
here is no dispatch specially event for loading Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.
Only general core_collection_abstract_load_before was dispatched.

After
here is dispatch general core_collection_abstract_load_before and catalog_product_option_value_collection event for load before(+ _load_before) and after (+ _load_after) for Magento\Catalog\Model\ResourceModel\Product\Option\Value\Collection.

[engcom-Alfa]

Hi @sidolov .

Could you put an appropriate label for test coverage?
Thanks!

[gabrieldagama]

@magento run Semantic Version Checker

[gabrieldagama]

Approval internal ticket: https://jira.corp.magento.com/browse/MC-38732

[m2-assistant]

Hi @sprankhub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.